mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Reiss" <woggl...@gmail.com>
Subject Re: Review Request: Build third_party out of tarballs instead of distributing unpacked source
Date Wed, 01 Feb 2012 02:25:15 GMT


> On 2012-02-01 00:19:15, Benjamin Hindman wrote:
> > third_party/Makefile.am, line 4
> > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line4>
> >
> >     Why @SUBCONFIG_ARGS@ instead of $(SUBCONFIG_ARGS)?

That would be recursive on this line (since we are defining SUBCONFIG_ARGS for make purposes
but not .in substitution purposes).


> On 2012-02-01 00:19:15, Benjamin Hindman wrote:
> > src/Makefile.am, lines 22-23
> > <https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line22>
> >
> >     s/move/Move and kill tab (or indentation).

Done.


> On 2012-02-01 00:19:15, Benjamin Hindman wrote:
> > third_party/Makefile.am, line 2
> > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line2>
> >
> >     Not used.

Removed.


> On 2012-02-01 00:19:15, Benjamin Hindman wrote:
> > third_party/Makefile.am, line 73
> > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line73>
> >
> >     Kill tab.

Done.


> On 2012-02-01 00:19:15, Benjamin Hindman wrote:
> > third_party/Makefile.am, line 48
> > <https://reviews.apache.org/r/3588/diff/3/?file=70277#file70277line48>
> >
> >     Wrap for 80 characters please (and everywhere else in this file).

Done.


> On 2012-02-01 00:19:15, Benjamin Hindman wrote:
> > src/Makefile.am, line 45
> > <https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line45>
> >
> >     Wrap for 80 characters please.

Done.


> On 2012-02-01 00:19:15, Benjamin Hindman wrote:
> > src/Makefile.am, lines 77-78
> > <https://reviews.apache.org/r/3588/diff/3/?file=70274#file70274line77>
> >
> >     I've replaced '$(top_builddir)' with '..' everywhere else in the file.

You haven't, but replaced my additions of $(top_builddir) with ..


- Charles


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3588/#review4725
-----------------------------------------------------------


On 2012-02-01 02:25:11, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3588/
> -----------------------------------------------------------
> 
> (Updated 2012-02-01 02:25:11)
> 
> 
> Review request for mesos.
> 
> 
> Summary
> -------
> 
> Builds third_party from tarballs instead of having us distribute the unpacked source.
> 
> To make it sane to review, this patch does not include the tarballs or the removal of
the original third_party directories. Everything but distribute-* should be put into tarballs
for this to work.
> 
> 
> This addresses bug MESOS-120.
>     https://issues.apache.org/jira/browse/MESOS-120
> 
> 
> Diffs
> -----
> 
>   Makefile.am d979bbb 
>   Makefile.am d979bbb 
>   configure.ac 283b49a 
>   configure.ac 283b49a 
>   src/Makefile.am ac0a209 
>   src/Makefile.am ac0a209 
>   src/examples/python/test-executor.in d730116 
>   src/examples/python/test-executor.in d730116 
>   src/examples/python/test-framework.in 0f6a6a9 
>   src/examples/python/test-framework.in 0f6a6a9 
>   src/python/setup.py.in 07aaa58 
>   src/python/setup.py.in 07aaa58 
>   src/tests/base_zookeeper_test.cpp 872bffb 
>   src/tests/base_zookeeper_test.cpp 872bffb 
>   third_party/Makefile.am PRE-CREATION 
>   third_party/Makefile.am PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/3588/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message