Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Date: Tue, 24 Jan 2012 22:16:43 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: mesos-dev@incubator.apache.org
Message-ID: 
 <825628673.74365.1327443403178.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <522954441.70800.1327390303658.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MESOS-132) src/examples/java/test-executor,
 etc. assume non-POSIX sh
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MESOS-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192611#comment-13192611 ] 

jiraposter@reviews.apache.org commented on MESOS-132:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3603/#review4571
-----------------------------------------------------------

Ship it!


LGTM.


src/examples/python/test-executor.in
<https://reviews.apache.org/r/3603/#comment10197>

    This (and python/test-framework) should probably be moved about the use of ${RED} in the PYTHON env. var. message.


- Charles


On 2012-01-24 22:10:46, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3603/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-24 22:10:46)
bq.  
bq.  
bq.  Review request for mesos and Charles Reiss.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  See MESOS-132.
bq.  
bq.  
bq.  This addresses bug MESOS-132.
bq.      https://issues.apache.org/jira/browse/MESOS-132
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    bin/gdb-mesos-local.sh.in 65c4340 
bq.    bin/gdb-mesos-master.sh.in 716ab66 
bq.    bin/gdb-mesos-slave.sh.in 7f0c15f 
bq.    bin/mesos-local.sh.in 784da4b 
bq.    bin/mesos-master.sh.in 770e197 
bq.    bin/mesos-slave.sh.in 44f2c0d 
bq.    src/examples/java/test-exception-framework.in ae6d6cf 
bq.    src/examples/java/test-executor.in ab746c6 
bq.    src/examples/java/test-framework.in b0d2961 
bq.    src/examples/java/test-multiple-executors-framework.in b8796d6 
bq.    src/examples/python/test-executor.in d28fc51 
bq.    src/examples/python/test-framework.in 2841e17 
bq.  
bq.  Diff: https://reviews.apache.org/r/3603/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


> src/examples/java/test-executor, etc. assume non-POSIX sh
> ---------------------------------------------------------
>
>                 Key: MESOS-132
>                 URL: https://issues.apache.org/jira/browse/MESOS-132
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Charles Reiss
>            Priority: Minor
>              Labels: examples
>
> src/examples/java/test-executor and others use 'source', but a POSIX only requires (and, e.g. dash only implements) the name '.' for that command.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira