Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: mesos-dev@incubator.apache.org
Date: Tue, 10 Jan 2012 17:03:40 +0000 (UTC)
From: "jiraposter@reviews.apache.org (Commented) (JIRA)" <jira@apache.org>
To: mesos-dev@incubator.apache.org
Message-ID: 
 <759212958.25970.1326215020510.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <533450233.16003.1319590112121.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (MESOS-45) Document semantics and state
 transitions in mesos user-pluggable interfaces
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13183377#comment-13183377 ] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------


bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/Scheduler.java, line 57
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67453#file67453line57>
bq.  >
bq.  >     There appears to be no need fo indexed access - Collection if you want to provide size, but it seems Iterable is fine here.
bq.  
bq.  Matei Zaharia wrote:
bq.      Going over the offers in the same order multiple times is useful in complex schedulers -- for example, we do it in Spark. I suggest leaving it this way, unless you want everyone to copy their Collection to a list. I can't anticipate a scenario when it would be more efficient to use an unordered collection here, and in other languages, such as Python, the collection will be ordered anyway.

The comment wasn't derived from efficiency concerns - a List could still be passed since its Iterable.  I was suggesting this change as an api maintainer - Iterable gives you more freedom going forward to change implementation without breaking clients and your clients still get a sequence of offers they can repeatedly iterate over.  You might add extra javadoc that says the iterators are guaranteed to be stable wrt each other, but this is implicit for all Iterables I've encountered in java land.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4294
-----------------------------------------------------------


On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 06:48:03)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois, and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp d883f1a 
bq.    include/mesos/mesos.proto 77a9067 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java 5ad8cee 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
bq.    src/python/src/mesos.py 5fc60e2 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira