Return-Path: X-Original-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-mesos-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 280219A6F for ; Tue, 24 Jan 2012 22:13:18 +0000 (UTC) Received: (qmail 50475 invoked by uid 500); 24 Jan 2012 22:13:18 -0000 Delivered-To: apmail-incubator-mesos-dev-archive@incubator.apache.org Received: (qmail 50438 invoked by uid 500); 24 Jan 2012 22:13:17 -0000 Mailing-List: contact mesos-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: mesos-dev@incubator.apache.org Delivered-To: mailing list mesos-dev@incubator.apache.org Received: (qmail 50423 invoked by uid 99); 24 Jan 2012 22:13:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jan 2012 22:13:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 47B7B1C0B14; Tue, 24 Jan 2012 22:13:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4667844414702774999==" MIME-Version: 1.0 Subject: Re: Review Request: Add $(PYTHON_LDFLAGS) to libwebui_la_LIBADD From: "Benjamin Hindman" To: "Benjamin Hindman" , "mesos" , "Charles Reiss" Date: Tue, 24 Jan 2012 22:13:17 -0000 Message-ID: <20120124221317.8384.59552@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org X-ReviewRequest-URL: https://reviews.apache.org/r/3590/ In-Reply-To: <20120123074503.8384.45467@reviews.apache.org> References: <20120123074503.8384.45467@reviews.apache.org> --===============4667844414702774999== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3590/#review4570 ----------------------------------------------------------- src/Makefile.am Cool, does this mean we can also remove all WEBUI_LDFLAGS from the bina= ries too? - Benjamin On 2012-01-23 07:45:03, Charles Reiss wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3590/ > ----------------------------------------------------------- > = > (Updated 2012-01-23 07:45:03) > = > = > Review request for mesos. > = > = > Summary > ------- > = > This can be necessary to link mesos-master because the -lpython* flag nee= ds to end up after libwebui.a on some systems. Using LIBADD tells libtool t= hat libwebui.a depends on it so it generates an appropriately ordered linki= ng command. > = > = > This addresses bug MESOS-131. > https://issues.apache.org/jira/browse/MESOS-131 > = > = > Diffs > ----- > = > src/Makefile.am b8fc58e = > = > Diff: https://reviews.apache.org/r/3590/diff > = > = > Testing > ------- > = > = > Thanks, > = > Charles > = > --===============4667844414702774999==--