mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Add $(PYTHON_LDFLAGS) to libwebui_la_LIBADD
Date Tue, 24 Jan 2012 22:13:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3590/#review4570
-----------------------------------------------------------



src/Makefile.am
<https://reviews.apache.org/r/3590/#comment10196>

    Cool, does this mean we can also remove all WEBUI_LDFLAGS from the binaries too?


- Benjamin


On 2012-01-23 07:45:03, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3590/
> -----------------------------------------------------------
> 
> (Updated 2012-01-23 07:45:03)
> 
> 
> Review request for mesos.
> 
> 
> Summary
> -------
> 
> This can be necessary to link mesos-master because the -lpython* flag needs to end up
after libwebui.a on some systems. Using LIBADD tells libtool that libwebui.a depends on it
so it generates an appropriately ordered linking command.
> 
> 
> This addresses bug MESOS-131.
>     https://issues.apache.org/jira/browse/MESOS-131
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am b8fc58e 
> 
> Diff: https://reviews.apache.org/r/3590/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message