mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Make 'make clean' clean more generated files.
Date Tue, 24 Jan 2012 21:43:22 GMT


> On 2012-01-24 21:23:29, Benjamin Hindman wrote:
> > src/Makefile.am, line 387
> > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line387>
> >
> >     If we don't build with java, does 'make clean' complain if these don't exist?
What's the cons to sticking all the clean stuff (including the clean-java/clean-python) targets
within 'if HAS_JAVA' (or 'if HAS_PYTHON')?
> 
> Charles Reiss wrote:
>     make clean needs to work even if you didn't build, so it shouldn't.

If we need 'clean-java' to be outside of the 'if HAS_JAVA' block, then I think it should be
at the bottom of that block to make it easier to understand. Likewise, we can put CLEANFILES
for MESOS_JAR and EXAMPLES_JAR inside the if HAS_JAVA block next to their targets (in fact,
I think MESOS_JAR was already there, but not by itself). Likewise, I'd like to move the clean-python
one too.


> On 2012-01-24 21:23:29, Benjamin Hindman wrote:
> > src/Makefile.am, line 508
> > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line508>
> >
> >     Why is this needed?
> 
> Charles Reiss wrote:
>     The distribution will tar most things up without write permission set. cp -pf will
preserve this, so python/native will contain many read-only files.

Gotcha, thanks.


> On 2012-01-24 21:23:29, Benjamin Hindman wrote:
> > src/Makefile.am, line 677
> > <https://reviews.apache.org/r/3587/diff/1/?file=70255#file70255line677>
> >
> >     Does 'make check' create the test_output directory?
> 
> Charles Reiss wrote:
>     The external tests create it somehow, I don't know the exact mechanism offhand.

Right.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3587/#review4561
-----------------------------------------------------------


On 2012-01-23 03:33:37, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3587/
> -----------------------------------------------------------
> 
> (Updated 2012-01-23 03:33:37)
> 
> 
> Review request for mesos.
> 
> 
> Summary
> -------
> 
> 'make clean' is currently missing a few generated files; this adds them.
> 
> Also makes mesos_pb2.py be generated directly in python/src instead of being copied there.
> 
> Part of MESOS-120 because this is necessary for 'make distcheck' to pass.
> 
> 
> This addresses bug MESOS-120.
>     https://issues.apache.org/jira/browse/MESOS-120
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am b8fc58e 
> 
> Diff: https://reviews.apache.org/r/3587/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message