mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request: Correct int j = j + 1 to int j = i + 1 in Resources::isAllocatable
Date Mon, 23 Jan 2012 01:19:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3583/#review4526
-----------------------------------------------------------

Ship it!


Wow, I thought this bug was fixed! Oh the perils of two different code repositories ... but
no more! ;) I'll commit this right away. Thanks Charles.

- Benjamin


On 2012-01-22 20:44:30, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3583/
> -----------------------------------------------------------
> 
> (Updated 2012-01-22 20:44:30)
> 
> 
> Review request for mesos.
> 
> 
> Summary
> -------
> 
> int j = j + 1 didn't make any sense; I assume int i = i + 1 was meant so the check would
be done on all pairs.
> 
> 
> This addresses bug MESOS-129.
>     https://issues.apache.org/jira/browse/MESOS-129
> 
> 
> Diffs
> -----
> 
>   src/common/resources.hpp 350e75d 
> 
> Diff: https://reviews.apache.org/r/3583/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message