mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-45) Document semantics and state transitions in mesos user-pluggable interfaces
Date Wed, 25 Jan 2012 01:56:45 GMT

    [ https://issues.apache.org/jira/browse/MESOS-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192786#comment-13192786
] 

jiraposter@reviews.apache.org commented on MESOS-45:
----------------------------------------------------



bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > This is very, very helpful.  Thanks.
bq.  > I focused on the javadoc but threw in java api nits as well (from the perspective
of a mesos library maintainer).
bq.  > The javadoc should really follow http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html,
 but the most glaring omissions are @parameter,@return docs.

Yes, I'd love to see these too. Perhaps this will get done in the second round, or could get
contributed by someone else.


bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/Scheduler.java, line 39
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67453#file67453line39>
bq.  >
bq.  >     The driver parameter in all methods other than register deserves explanation
- must I use the it in the scope of the callback or is it always the same as the regsitered
or ...?

Done.


bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/SchedulerDriver.java, line 38
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67454#file67454line38>
bq.  >
bq.  >     s/public // - these are redundant for interface members

Done.


bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/SchedulerDriver.java, line 43
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67454#file67454line43>
bq.  >
bq.  >     how does this stop relate to the overload?  failover=true or false?

Updated the comment. Thanks.


bq.  On 2012-01-10 14:26:24, John Sirois wrote:
bq.  > src/java/src/org/apache/mesos/SchedulerDriver.java, line 85
bq.  > <https://reviews.apache.org/r/3442/diff/1/?file=67454#file67454line85>
bq.  >
bq.  >     Is Iterable enough for the impl? - if so prefer it.

This is a much more invasive change (updates to the JNI bindings are required). If you feel
highly about this please create a JIRA, and feel free to submit a patch too!. ;)


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3442/#review4294
-----------------------------------------------------------


On 2012-01-10 06:48:03, Benjamin Hindman wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3442/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-01-10 06:48:03)
bq.  
bq.  
bq.  Review request for mesos, Andy Konwinski, Charles Reiss, Matei Zaharia, John Sirois,
and Vinod Kone.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Provides initial documentation to the public interfaces (thanks to Vinod Kone for pairing
with me on this).
bq.  
bq.  
bq.  This addresses bug MESOS-45.
bq.      https://issues.apache.org/jira/browse/MESOS-45
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/executor.hpp d883f1a 
bq.    include/mesos/mesos.proto 77a9067 
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/java/src/org/apache/mesos/Executor.java 5ad8cee 
bq.    src/java/src/org/apache/mesos/ExecutorDriver.java be01d21 
bq.    src/java/src/org/apache/mesos/MesosExecutorDriver.java 399c8b8 
bq.    src/java/src/org/apache/mesos/MesosSchedulerDriver.java 04809a6 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/java/src/org/apache/mesos/SchedulerDriver.java 23a246c 
bq.    src/python/src/mesos.py 5fc60e2 
bq.  
bq.  Diff: https://reviews.apache.org/r/3442/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Benjamin
bq.  
bq.


                
> Document semantics and state transitions in mesos user-pluggable interfaces
> ---------------------------------------------------------------------------
>
>                 Key: MESOS-45
>                 URL: https://issues.apache.org/jira/browse/MESOS-45
>             Project: Mesos
>          Issue Type: Improvement
>          Components: c++-api, java-api, python-api
>            Reporter: John Sirois
>
> In particular, scheduler and executor lifecycle and re-entrancy requirements should be
documented well either centrally, in a HOW-TO/spec or better, additionally or solely in binding
interfaces in the supported languages (cpp, java, python).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message