mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-86) Expose master url to the scheduler
Date Mon, 19 Dec 2011 19:57:33 GMT

    [ https://issues.apache.org/jira/browse/MESOS-86?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172553#comment-13172553
] 

jiraposter@reviews.apache.org commented on MESOS-86:
----------------------------------------------------



bq.  On 2011-12-15 00:30:09, Benjamin Hindman wrote:
bq.  > src/java/jni/convert.cpp, line 49
bq.  > <https://reviews.apache.org/r/3083/diff/1/?file=63411#file63411line49>
bq.  >
bq.  >     I see this got added, but it's not used? I know in a previous review (internal)
I had suggested this ... did the rest of the code that was part of it get dropped? If so,
we should drop this too.

hmm..looks like a bad diff merge...let me get the correct diff


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3083/#review3917
-----------------------------------------------------------


On 2011-12-09 02:41:32, Vinod Kone wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3083/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-12-09 02:41:32)
bq.  
bq.  
bq.  Review request for mesos, Benjamin Hindman and John Sirois.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.      New Scheduler callbacks for master info (ip and port)
bq.      
bq.      --> registered() callback now includes maste info 
bq.      --> new re-registered() callback is called when a new master is elected
bq.      --> new masterLost() callback is called when mesos core doesnt detect an
bq.      active master (e.g: during election)
bq.  
bq.  
bq.  This addresses bug MESOS-86.
bq.      https://issues.apache.org/jira/browse/MESOS-86
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    include/mesos/scheduler.hpp 93dda98 
bq.    src/examples/cpp_test_framework.cpp ab02805 
bq.    src/examples/java/TestExceptionFramework.java ba39757 
bq.    src/examples/java/TestFramework.java e1b6032 
bq.    src/examples/java/TestMultipleExecutorsFramework.java a49ecbb 
bq.    src/examples/long_lived_framework.cpp 4003e47 
bq.    src/examples/memhog.cpp 339d238 
bq.    src/examples/python/test_framework.py e6893cf 
bq.    src/examples/scheduled_memhog.cpp 5d01aef 
bq.    src/java/jni/convert.cpp 04a25dd 
bq.    src/java/jni/org_apache_mesos_MesosSchedulerDriver.cpp 8704663 
bq.    src/java/src/org/apache/mesos/Scheduler.java 63a06fe 
bq.    src/master/master.cpp ede831e 
bq.    src/messages/messages.proto a9cbcdc 
bq.    src/python/native/proxy_scheduler.hpp a348cbb 
bq.    src/python/native/proxy_scheduler.cpp 934820a 
bq.    src/python/src/mesos.py 5fc60e2 
bq.    src/sched/sched.cpp 7f4e980 
bq.    src/tests/exception_tests.cpp 62f4fb6 
bq.    src/tests/fault_tolerance_tests.cpp ebb7709 
bq.    src/tests/master_tests.cpp a1f5007 
bq.    src/tests/resource_offers_tests.cpp 8e1061e 
bq.    src/tests/utils.hpp 65ce4df 
bq.  
bq.  Diff: https://reviews.apache.org/r/3083/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  ./bin/tests/all-tests
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Vinod
bq.  
bq.


                
> Expose master url to the scheduler
> ----------------------------------
>
>                 Key: MESOS-86
>                 URL: https://issues.apache.org/jira/browse/MESOS-86
>             Project: Mesos
>          Issue Type: New Feature
>            Reporter: Vinod Kone
>            Assignee: Vinod Kone
>
> Introduce new / augment old api calls (callbacks) to expose the master url.
> Currently there is no way for the scheduler to know what the leading master is. It would
be useful for scheduler's to know this information (e.g: pointing to the webui of the leading
master). Here is the plan:
> 1) Augment registered() callback to included this info
> 2) Implement new callback re-registered() that gets called whenever a master re-election
happens. This also contains the new master url.
> 3) Also implement a new callback masterLost()  that gets called whenever the current
master loses election.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message