mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-59) Test macros in tests/utils.hpp aren't robust
Date Mon, 14 Nov 2011 20:31:03 GMT

    [ https://issues.apache.org/jira/browse/MESOS-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149886#comment-13149886
] 

jiraposter@reviews.apache.org commented on MESOS-59:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/#review3225
-----------------------------------------------------------


- Charles


On 2011-11-02 23:45:46, Charles Reiss wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2685/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-11-02 23:45:46)
bq.  
bq.  
bq.  Review request for mesos.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  See description of bugs in MESOS-59.
bq.  
bq.  
bq.  This addresses bug MESOS-59.
bq.      https://issues.apache.org/jira/browse/MESOS-59
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    src/tests/utils.hpp 02772f7 
bq.  
bq.  Diff: https://reviews.apache.org/r/2685/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Charles
bq.  
bq.


                
> Test macros in tests/utils.hpp aren't robust
> --------------------------------------------
>
>                 Key: MESOS-59
>                 URL: https://issues.apache.org/jira/browse/MESOS-59
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Charles Reiss
>            Assignee: Charles Reiss
>            Priority: Trivial
>
> The EXPECT_MSG macro in tests/utils.hpp won't work if the MockFilter object is called
anythig but filter (because it's the method and macro argument name).
> The WAIT_UNTIL macro in tests/utils.hpp doesn't put parens around its argument so something
like WAIT_UNTIL(&trigger) will always return immediately instead of causing a compilation
error.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message