mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andy Konwinski" <an...@berkeley.edu>
Subject Re: Review Request: include more header files in tests/process_spawn.cpp
Date Thu, 10 Nov 2011 08:34:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2663/#review3152
-----------------------------------------------------------

Ship it!


Looks great, thanks Charles!

- Andy


On 2011-11-02 23:16:55, Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2663/
> -----------------------------------------------------------
> 
> (Updated 2011-11-02 23:16:55)
> 
> 
> Review request for mesos.
> 
> 
> Summary
> -------
> 
> Currently, tests/process_spawn.cpp uses INT_MAX but only includes <iostream> which
is not gaurenteed (and apparently does not on some systems) to define INT_MAX, causing a compilation
error.
> 
> 
> This addresses bug MESOS-37.
>     https://issues.apache.org/jira/browse/MESOS-37
> 
> 
> Diffs
> -----
> 
>   src/tests/process_spawn.cpp 4f60296 
> 
> Diff: https://reviews.apache.org/r/2663/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Charles
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message