mesos-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Charles Reiss" <woggl...@gmail.com>
Subject Re: Review Request: include <limits.h> for INT_MAX in tests/process_spawn.cpp
Date Wed, 02 Nov 2011 23:16:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2663/
-----------------------------------------------------------

(Updated 2011-11-02 23:16:39.597586)


Review request for mesos.


Changes
-------

Also add <cstdio> (needed for Ubuntu according to MESOS-37 reporter) and <unistd.h>.

This problem suggests we should run include-what-you-use over the Mesos codebase in the future.


Summary
-------

Currently, tests/process_spawn.cpp uses INT_MAX but only includes <iostream> which is
not gaurenteed (and apparently does not on some systems) to define INT_MAX, causing a compilation
error.


This addresses bug MESOS-37.
    https://issues.apache.org/jira/browse/MESOS-37


Diffs (updated)
-----

  src/tests/process_spawn.cpp 4f60296 

Diff: https://reviews.apache.org/r/2663/diff


Testing
-------


Thanks,

Charles


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message