mesos-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bbann...@apache.org
Subject [mesos] branch master updated: Invoked base test `SetUp` and `TearDown` methods in derived tests.
Date Fri, 11 Jan 2019 23:29:53 GMT
This is an automated email from the ASF dual-hosted git repository.

bbannier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git


The following commit(s) were added to refs/heads/master by this push:
     new cff4254  Invoked base test `SetUp` and `TearDown` methods in derived tests.
cff4254 is described below

commit cff4254907362eff27f12e1b512e248060a9b9d4
Author: Benjamin Bannier <benjamin.bannier@mesosphere.io>
AuthorDate: Sat Jan 12 00:26:46 2019 +0100

    Invoked base test `SetUp` and `TearDown` methods in derived tests.
    
    This patch adds required invocations of base class `Setup` and
    `TearDown` in more derived classes. Unfortunately googletest provides no
    indirection (e.g., via applying the template method pattern) and we do
    have to take care of this ourself.
    
    These missing cases were identified with the following clang query with
    `METHOD` either `"SetUp"` or `"TearDown"`
    
        match cxxMethodDecl(
            ofClass(isDerivedFrom("::testing::Test")),
            unless(isImplicit()),
            hasName(METHOD),
            isOverride(),
            unless(hasDescendant(cxxMemberCallExpr(
                hasDeclaration(cxxMethodDecl(hasName(METHOD), isVirtual()))))))
    
    and subsequentially fixing all true positives.
    
    Review: https://reviews.apache.org/r/69728/
---
 src/tests/containerizer/docker_tests.cpp | 4 ++++
 src/tests/csi_client_tests.cpp           | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/src/tests/containerizer/docker_tests.cpp b/src/tests/containerizer/docker_tests.cpp
index 0eefbd9..be826cf 100644
--- a/src/tests/containerizer/docker_tests.cpp
+++ b/src/tests/containerizer/docker_tests.cpp
@@ -74,6 +74,8 @@ class DockerTest : public MesosTest
 {
   void SetUp() override
   {
+    MesosTest::SetUp();
+
     Future<Nothing> pull = pullDockerImage(DOCKER_TEST_IMAGE);
 
     LOG_FIRST_N(WARNING, 1) << "Downloading " << string(DOCKER_TEST_IMAGE)
@@ -102,6 +104,8 @@ class DockerTest : public MesosTest
     foreach (const Docker::Container& container, containers.get()) {
       AWAIT_READY_FOR(docker.get()->rm(container.id, true), Seconds(30));
     }
+
+    MesosTest::TearDown();
   }
 
 protected:
diff --git a/src/tests/csi_client_tests.cpp b/src/tests/csi_client_tests.cpp
index 3d4a062..7751636 100644
--- a/src/tests/csi_client_tests.cpp
+++ b/src/tests/csi_client_tests.cpp
@@ -95,6 +95,8 @@ protected:
     AWAIT_ASSERT_READY(runtime.wait());
 
     ASSERT_SOME(plugin.shutdown());
+
+    TemporaryDirectoryTest::TearDown();
   }
 
   MockCSIPlugin plugin;


Mime
View raw message