mesos-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ne...@apache.org
Subject [2/4] mesos git commit: Removed redundant call to `std::string::c_str()` in Mesos.
Date Thu, 30 Mar 2017 16:53:52 GMT
Removed redundant call to `std::string::c_str()` in Mesos.

Spotted using the "readability-redundant-string-cstr" clang-tidy check.

Review: https://reviews.apache.org/r/58038


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/5eec2a0b
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/5eec2a0b
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/5eec2a0b

Branch: refs/heads/master
Commit: 5eec2a0b5ed0dacf5b54ed73fda559dd54ddad4a
Parents: 0782281
Author: Neil Conway <neil.conway@gmail.com>
Authored: Mon Mar 13 19:29:54 2017 -0700
Committer: Neil Conway <neil.conway@gmail.com>
Committed: Thu Mar 30 09:51:33 2017 -0700

----------------------------------------------------------------------
 src/tests/containerizer/docker_volume_isolator_tests.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/5eec2a0b/src/tests/containerizer/docker_volume_isolator_tests.cpp
----------------------------------------------------------------------
diff --git a/src/tests/containerizer/docker_volume_isolator_tests.cpp b/src/tests/containerizer/docker_volume_isolator_tests.cpp
index 13a1f13..b47a6b5 100644
--- a/src/tests/containerizer/docker_volume_isolator_tests.cpp
+++ b/src/tests/containerizer/docker_volume_isolator_tests.cpp
@@ -102,9 +102,9 @@ protected:
   {
     // Try to remove any mounts under sandbox.
     if (::geteuid() == 0) {
-      Try<Nothing> unmountAll = fs::unmountAll(sandbox->c_str(), MNT_DETACH);
+      Try<Nothing> unmountAll = fs::unmountAll(sandbox.get(), MNT_DETACH);
       if (unmountAll.isError()) {
-        LOG(ERROR) << "Failed to unmount '" << sandbox->c_str()
+        LOG(ERROR) << "Failed to unmount '" << sandbox.get()
                    << "': " << unmountAll.error();
         return;
       }


Mime
View raw message