mesos-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bmah...@apache.org
Subject [1/6] mesos git commit: Added TODOs to the framework and agent capabilities helpers.
Date Mon, 27 Feb 2017 23:23:59 GMT
Repository: mesos
Updated Branches:
  refs/heads/master 277dd384c -> ab2865500


Added TODOs to the framework and agent capabilities helpers.

With the current approach, unknown capabilities are dropped
since we do not store the protobuf.


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/89080f72
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/89080f72
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/89080f72

Branch: refs/heads/master
Commit: 89080f7271d70aad876acd95c23cafec1e37e6da
Parents: 277dd38
Author: Benjamin Mahler <bmahler@apache.org>
Authored: Mon Feb 27 14:58:04 2017 -0800
Committer: Benjamin Mahler <bmahler@apache.org>
Committed: Mon Feb 27 14:59:49 2017 -0800

----------------------------------------------------------------------
 src/common/protobuf_utils.hpp | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/89080f72/src/common/protobuf_utils.hpp
----------------------------------------------------------------------
diff --git a/src/common/protobuf_utils.hpp b/src/common/protobuf_utils.hpp
index 4f69483..ae1467d 100644
--- a/src/common/protobuf_utils.hpp
+++ b/src/common/protobuf_utils.hpp
@@ -139,6 +139,8 @@ ContainerID getRootContainerId(const ContainerID& containerId);
 
 namespace slave {
 
+// TODO(bmahler): Store the repeated field within this so that we
+// don't drop unknown capabilities.
 struct Capabilities
 {
   Capabilities() = default;
@@ -256,6 +258,8 @@ mesos::master::Event createAgentRemoved(const SlaveID& slaveId);
 
 namespace framework {
 
+// TODO(bmahler): Store the repeated field within this so that we
+// don't drop unknown capabilities.
 struct Capabilities
 {
   Capabilities() = default;


Mime
View raw message