mesos-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From al...@apache.org
Subject [3/5] mesos git commit: Fix libprocess build option argument handling.
Date Tue, 28 Feb 2017 08:52:51 GMT
Fix libprocess build option argument handling.

Fix all the AC_ARG_ENABLED options to correctly handle --enable-foo
and --disable-foo variants. Update all the invocations to have a
consistent calling convention.

Review: https://reviews.apache.org/r/53138/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/12877b39
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/12877b39
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/12877b39

Branch: refs/heads/1.1.x
Commit: 12877b39bed68dea052b90effeffa23c97bfdfe3
Parents: cbb4cd1
Author: James Peach <jpeach@apache.org>
Authored: Thu Nov 3 15:51:04 2016 -0400
Committer: Alexander Rukletsov <alexr@apache.org>
Committed: Tue Feb 28 09:40:19 2017 +0100

----------------------------------------------------------------------
 3rdparty/libprocess/configure.ac | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/12877b39/3rdparty/libprocess/configure.ac
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/configure.ac b/3rdparty/libprocess/configure.ac
index dcbb8b9..0500d4e 100644
--- a/3rdparty/libprocess/configure.ac
+++ b/3rdparty/libprocess/configure.ac
@@ -73,13 +73,13 @@ AC_ARG_ENABLE([bundled],
               AS_HELP_STRING([--disable-bundled],
                              [build against preinstalled dependencies instead
                              of bundled libraries]),
-              [enable_bundled=no], [enable_bundled=yes])
+              [], [enable_bundled=yes])
 
 AC_ARG_ENABLE([debug],
               AS_HELP_STRING([--enable-debug],
                              [enable debugging. If CFLAGS/CXXFLAGS are set, this
                               option won't change them default: no]),
-              [enable_debug=yes], [])
+              [], [enable_debug=no])
 
 AC_ARG_ENABLE([install],
               AS_HELP_STRING([--enable-install],
@@ -89,36 +89,36 @@ AC_ARG_ENABLE([install],
 AC_ARG_ENABLE([libevent],
               AS_HELP_STRING([--enable-libevent],
                              [use libevent instead of libev default: no]),
-              [enable_libevent=yes], [])
+              [], [enable_libevent=no])
 
 AC_ARG_ENABLE([optimize],
               AS_HELP_STRING([--enable-optimize],
                              [enable optimizations. If CFLAGS/CXXFLAGS are set,
                               this option won't change them default: no]),
-              [enable_optimize=yes], [])
+              [], [enable_optimize=no])
 
 AC_ARG_ENABLE([perftools],
               AS_HELP_STRING([--enable-perftools],
-                             [enable google perftools]),
-              [gperftools=yes], [])
+                             [enable Google perftools]),
+              [], [enable_perftools=no])
 
 AC_ARG_ENABLE([ssl],
               AS_HELP_STRING([--enable-ssl],
                              [use ssl for libprocess communication
                              default: no]),
-              [enable_ssl=yes], [])
+              [], [enable_ssl=no])
 
 AC_ARG_ENABLE([static-unimplemented],
               AS_HELP_STRING([--enable-static-unimplemented],
                              [generate static assertion errors for unimplemented
                              functions default: no]),
-              [enable_static_unimplemented=yes], [])
+              [], [enable_static_unimplemented=no])
 
 AC_ARG_ENABLE([zlib],
             AS_HELP_STRING([--disable-zlib],
                            [disables zlib compression, which means the webui
                            will be far less responsive; not recommended]),
-            [enable_zlib=no], [enable_zlib=yes])
+            [], [enable_zlib=yes])
 
 
 ###############################################################################
@@ -344,7 +344,7 @@ if test "x$enable_static_unimplemented" = "xyes"; then
   AC_DEFINE([ENABLE_STATIC_UNIMPLEMENTED], [1])
 fi
 
-AM_CONDITIONAL([HAS_GPERFTOOLS], [test x"$gperftools" = "xyes"])
+AM_CONDITIONAL([HAS_GPERFTOOLS], [test x"$enable_perftools" = "xyes"])
 AM_COND_IF([HAS_GPERFTOOLS], AC_DEFINE([ENABLE_GPERFTOOLS], [1]))
 
 # Disable static libprocess by default.


Mime
View raw message