mesos-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vinodk...@apache.org
Subject mesos git commit: Fixed a check bug in LAUNCH_NESTED_CONTAINER_SESSION_CALL.
Date Wed, 14 Dec 2016 04:17:38 GMT
Repository: mesos
Updated Branches:
  refs/heads/master 959b97e90 -> e99ea9ce8


Fixed a check bug in LAUNCH_NESTED_CONTAINER_SESSION_CALL.

`attachContainerOutput` could return a non OK response (e.g., authz
error). We should return the response in this case instead of failing
the CHECK.

Review: https://reviews.apache.org/r/54731


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/e99ea9ce
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/e99ea9ce
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/e99ea9ce

Branch: refs/heads/master
Commit: e99ea9ce8b1de01dd8b3cac6675337edb6320f38
Parents: 959b97e
Author: Vinod Kone <vinodkone@gmail.com>
Authored: Tue Dec 13 20:13:38 2016 -0800
Committer: Vinod Kone <vinodkone@gmail.com>
Committed: Tue Dec 13 20:15:07 2016 -0800

----------------------------------------------------------------------
 src/slave/http.cpp | 4 ++++
 1 file changed, 4 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/e99ea9ce/src/slave/http.cpp
----------------------------------------------------------------------
diff --git a/src/slave/http.cpp b/src/slave/http.cpp
index 56c2879..4cd352f 100644
--- a/src/slave/http.cpp
+++ b/src/slave/http.cpp
@@ -2673,6 +2673,10 @@ Future<Response> Slave::Http::launchNestedContainerSession(
       return attachContainerOutput(call, contentType, acceptType, principal)
         .then(defer(slave->self(),
                     [=](const Response& response) -> Future<Response> {
+          if (response.status != OK().status) {
+            return response;
+          }
+
           Pipe pipe;
           Pipe::Writer writer = pipe.writer();
 


Mime
View raw message