mesos-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From josep...@apache.org
Subject [2/5] mesos git commit: CMake: Fixed typo in `-DHAS_AUTHENTICATION=0` instructions.
Date Tue, 20 Dec 2016 22:28:56 GMT
CMake: Fixed typo in `-DHAS_AUTHENTICATION=0` instructions.

Windows builds without this flag instruct you to add it,
but the instructions were missing the prefix `D` for define,
and so as-is resulted in an error message. This could be a
source of frustration for those unfamiliar with CMake.

Review: https://reviews.apache.org/r/54875/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/4a411b8a
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/4a411b8a
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/4a411b8a

Branch: refs/heads/master
Commit: 4a411b8aacfc9341aca71e9e10070fc5aaf29171
Parents: b743fb4
Author: Andrew Schwartzmeyer <andrew@schwartzmeyer.com>
Authored: Mon Dec 19 14:22:10 2016 -0800
Committer: Joseph Wu <josephwu@apache.org>
Committed: Tue Dec 20 12:48:34 2016 -0800

----------------------------------------------------------------------
 cmake/CompilationConfigure.cmake | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/4a411b8a/cmake/CompilationConfigure.cmake
----------------------------------------------------------------------
diff --git a/cmake/CompilationConfigure.cmake b/cmake/CompilationConfigure.cmake
index d857587..1349afb 100644
--- a/cmake/CompilationConfigure.cmake
+++ b/cmake/CompilationConfigure.cmake
@@ -59,7 +59,7 @@ if (WIN32 AND HAS_AUTHENTICATION)
     FATAL_ERROR
     "Windows builds of Mesos currently do not support agent to master "
     "authentication. To build without this capability, pass "
-    "`-HAS_AUTHENTICATION=0` as an argument when you run CMake.")
+    "`-DHAS_AUTHENTICATION=0` as an argument when you run CMake.")
 endif (WIN32 AND HAS_AUTHENTICATION)
 
 # If 'REBUNDLED' is set to FALSE, this will cause Mesos to build against


Mime
View raw message