mesos-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From al...@apache.org
Subject mesos git commit: Expanded the comment around `ContainerInfo` protobuf.
Date Tue, 06 Dec 2016 09:43:52 GMT
Repository: mesos
Updated Branches:
  refs/heads/master 100c2126c -> 55b892dd2


Expanded the comment around `ContainerInfo` protobuf.

Review: https://reviews.apache.org/r/53853/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/55b892dd
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/55b892dd
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/55b892dd

Branch: refs/heads/master
Commit: 55b892dd226f5927502c83981c4281a194c01307
Parents: 100c212
Author: Alexander Rukletsov <rukletsov@gmail.com>
Authored: Tue Dec 6 10:42:53 2016 +0100
Committer: Alexander Rukletsov <alexr@apache.org>
Committed: Tue Dec 6 10:42:53 2016 +0100

----------------------------------------------------------------------
 include/mesos/mesos.proto    | 7 +++++++
 include/mesos/v1/mesos.proto | 7 +++++++
 2 files changed, 14 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/55b892dd/include/mesos/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/mesos.proto b/include/mesos/mesos.proto
index 657dcb8..8279225 100644
--- a/include/mesos/mesos.proto
+++ b/include/mesos/mesos.proto
@@ -2178,6 +2178,13 @@ message TTYInfo {
 /**
  * Describes a container configuration and allows extensible
  * configurations for different container implementations.
+ *
+ * NOTE: `ContainerInfo` may be specified, e.g., by a task, even if no
+ * container image is provided. In this case neither `MesosInfo` nor
+ * `DockerInfo` is set, the required `type` must be `MESOS`. This is to
+ * address a case when a task without an image, e.g., a shell script
+ * with URIs, wants to use features originally designed for containers,
+ * for example custom network isolation via `NetworkInfo`.
  */
 message ContainerInfo {
   // All container implementation types.

http://git-wip-us.apache.org/repos/asf/mesos/blob/55b892dd/include/mesos/v1/mesos.proto
----------------------------------------------------------------------
diff --git a/include/mesos/v1/mesos.proto b/include/mesos/v1/mesos.proto
index 36c1227..4628cc6 100644
--- a/include/mesos/v1/mesos.proto
+++ b/include/mesos/v1/mesos.proto
@@ -2177,6 +2177,13 @@ message TTYInfo {
 /**
  * Describes a container configuration and allows extensible
  * configurations for different container implementations.
+ *
+ * NOTE: `ContainerInfo` may be specified, e.g., by a task, even if no
+ * container image is provided. In this case neither `MesosInfo` nor
+ * `DockerInfo` is set, the required `type` must be `MESOS`. This is to
+ * address a case when a task without an image, e.g., a shell script
+ * with URIs, wants to use features originally designed for containers,
+ * for example custom network isolation via `NetworkInfo`.
  */
 message ContainerInfo {
   // All container implementation types.


Mime
View raw message