mesos-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From al...@apache.org
Subject [2/3] mesos git commit: Escalated some openssl logs from VLOG to INFO.
Date Thu, 29 Sep 2016 16:58:34 GMT
Escalated some openssl logs from VLOG to INFO.

The logging messages in question prove to be very useful for debugging
the cluster setup and hence we decided they should be generally
available as their helpfulnes by far outwages their noise given that
we call these only during initializing.

Review: https://reviews.apache.org/r/52033/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/484165eb
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/484165eb
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/484165eb

Branch: refs/heads/master
Commit: 484165ebe89a8d9b0e74236ef2d2a21e2ad34b27
Parents: 620afd3
Author: Till Toenshoff <toenshoff@me.com>
Authored: Thu Sep 29 18:52:01 2016 +0200
Committer: Alexander Rukletsov <alexr@apache.org>
Committed: Thu Sep 29 18:52:01 2016 +0200

----------------------------------------------------------------------
 3rdparty/libprocess/src/openssl.cpp | 38 ++++++++++++++++----------------
 1 file changed, 19 insertions(+), 19 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/484165eb/3rdparty/libprocess/src/openssl.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/src/openssl.cpp b/3rdparty/libprocess/src/openssl.cpp
index cc207bc..b4ed511 100644
--- a/3rdparty/libprocess/src/openssl.cpp
+++ b/3rdparty/libprocess/src/openssl.cpp
@@ -413,39 +413,39 @@ void reinitialize()
   }
 
   if (ssl_flags->ca_file.isNone()) {
-    VLOG(2) << "CA file path is unspecified! NOTE: "
-            << "Set CA file path with LIBPROCESS_SSL_CA_FILE=<filepath>";
+    LOG(INFO) << "CA file path is unspecified! NOTE: "
+              << "Set CA file path with LIBPROCESS_SSL_CA_FILE=<filepath>";
   }
 
   if (ssl_flags->ca_dir.isNone()) {
-    VLOG(2) << "CA directory path unspecified! NOTE: "
-            << "Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>";
+    LOG(INFO) << "CA directory path unspecified! NOTE: "
+              << "Set CA directory path with LIBPROCESS_SSL_CA_DIR=<dirpath>";
   }
 
   if (!ssl_flags->verify_cert) {
-    VLOG(2) << "Will not verify peer certificate!\n"
-            << "NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable "
-            << "peer certificate verification";
+    LOG(INFO) << "Will not verify peer certificate!\n"
+              << "NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable "
+              << "peer certificate verification";
   }
 
   if (!ssl_flags->require_cert) {
-    VLOG(2) << "Will only verify peer certificate if presented!\n"
-            << "NOTE: Set LIBPROCESS_SSL_REQUIRE_CERT=1 to require "
-            << "peer certificate verification";
+    LOG(INFO) << "Will only verify peer certificate if presented!\n"
+              << "NOTE: Set LIBPROCESS_SSL_REQUIRE_CERT=1 to require "
+              << "peer certificate verification";
   }
 
   if (ssl_flags->verify_ipadd) {
-    VLOG(2) << "Will use IP address verification in subject alternative name "
-            << "certificate extension.";
+    LOG(INFO) << "Will use IP address verification in subject alternative name "
+              << "certificate extension.";
   }
 
   if (ssl_flags->require_cert && !ssl_flags->verify_cert) {
     // Requiring a certificate implies that is should be verified.
     ssl_flags->verify_cert = true;
 
-    VLOG(2) << "LIBPROCESS_SSL_REQUIRE_CERT implies "
-            << "peer certificate verification.\n"
-            << "LIBPROCESS_SSL_VERIFY_CERT set to true";
+    LOG(INFO) << "LIBPROCESS_SSL_REQUIRE_CERT implies "
+              << "peer certificate verification.\n"
+              << "LIBPROCESS_SSL_VERIFY_CERT set to true";
   }
 
   // Initialize OpenSSL if we've been asked to do verification of peer
@@ -472,18 +472,18 @@ void reinitialize()
       }
 
       if (ca_file != nullptr) {
-        VLOG(2) << "Using CA file: " << ca_file;
+        LOG(INFO) << "Using CA file: " << ca_file;
       }
       if (ca_dir != nullptr) {
-        VLOG(2) << "Using CA dir: " << ca_dir;
+        LOG(INFO) << "Using CA dir: " << ca_dir;
       }
     } else {
       if (SSL_CTX_set_default_verify_paths(ctx) != 1) {
         EXIT(EXIT_FAILURE) << "Could not load default CA file and/or directory";
       }
 
-      VLOG(2) << "Using default CA file '" << X509_get_default_cert_file()
-              << "' and/or directory '" << X509_get_default_cert_dir() <<
"'";
+      LOG(INFO) << "Using default CA file '" << X509_get_default_cert_file()
+                << "' and/or directory '" << X509_get_default_cert_dir() <<
"'";
     }
 
     // Set SSL peer verification callback.


Mime
View raw message