mesos-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bmah...@apache.org
Subject [2/2] mesos git commit: Cleaned up some logic in stout/elf.hpp.
Date Sat, 02 Jul 2016 23:58:49 GMT
Cleaned up some logic in stout/elf.hpp.

This logic originally worked around a bug in ELFIO. We now
include a .patch for ELFIO that makes this unnecessary.

Review: https://reviews.apache.org/r/49567/


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/60db4ced
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/60db4ced
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/60db4ced

Branch: refs/heads/master
Commit: 60db4cedab746159b198df20a19dbc57678baddb
Parents: a2d0a9e
Author: Kevin Klues <klueska@gmail.com>
Authored: Sat Jul 2 16:54:24 2016 -0700
Committer: Benjamin Mahler <bmahler@apache.org>
Committed: Sat Jul 2 16:54:24 2016 -0700

----------------------------------------------------------------------
 3rdparty/stout/include/stout/elf.hpp | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/60db4ced/3rdparty/stout/include/stout/elf.hpp
----------------------------------------------------------------------
diff --git a/3rdparty/stout/include/stout/elf.hpp b/3rdparty/stout/include/stout/elf.hpp
index 7ee840c..2bf91a0 100644
--- a/3rdparty/stout/include/stout/elf.hpp
+++ b/3rdparty/stout/include/stout/elf.hpp
@@ -175,10 +175,7 @@ public:
     }
 
     // Linux mandates `name == GNU`.
-    // However, ELFIO seems to include '\0' in the string itself
-    // when constructing `name`, so instead we make sure that
-    // `name` starts with "GNU" instead.
-    if (!strings::startsWith(name, "GNU")) {
+    if (name != "GNU") {
       return Error("Corrupt label '" + name + "' from"
                    " entry in '.note.ABI-tag' section");
     }


Mime
View raw message