mesos-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jo...@apache.org
Subject [03/11] mesos git commit: Removed glog signal handler installation on Windows.
Date Fri, 11 Sep 2015 00:25:54 GMT
Removed glog signal handler installation on Windows.

glog declares, but does not define the function
`google::InstallFailureSignalHandler`. If you try to compile a call to
this function, you will get a linker error.

Since we can't use it, this commit will remove that code on Windows.

Review: https://reviews.apache.org/r/37021


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/069f2e3b
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/069f2e3b
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/069f2e3b

Branch: refs/heads/master
Commit: 069f2e3b9ae28b54b6fd550f65662022726c7b73
Parents: 66b6ab8
Author: Alex Clemmer <clemmer.alexander@gmail.com>
Authored: Thu Sep 10 12:06:15 2015 -0700
Committer: Joris Van Remoortere <joris.van.remoortere@gmail.com>
Committed: Thu Sep 10 17:14:42 2015 -0700

----------------------------------------------------------------------
 3rdparty/libprocess/3rdparty/stout/tests/main.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/069f2e3b/3rdparty/libprocess/3rdparty/stout/tests/main.cpp
----------------------------------------------------------------------
diff --git a/3rdparty/libprocess/3rdparty/stout/tests/main.cpp b/3rdparty/libprocess/3rdparty/stout/tests/main.cpp
index 1410cf1..d959216 100644
--- a/3rdparty/libprocess/3rdparty/stout/tests/main.cpp
+++ b/3rdparty/libprocess/3rdparty/stout/tests/main.cpp
@@ -23,8 +23,12 @@ int main(int argc, char** argv)
   // Initialize Google Mock/Test.
   testing::InitGoogleMock(&argc, argv);
 
-  // Install GLOG's signal handler.
+#ifndef __WINDOWS__
+  // Install glog's signal handler. NOTE: this function is declared but not
+  // defined on Windows, so if we attempt to compile this on Windows, we get
+  // a linker error.
   google::InstallFailureSignalHandler();
+#endif // __WINDOWS__
 
   return RUN_ALL_TESTS();
 }


Mime
View raw message