maven-wagon-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilles Scokart (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (WAGON-30) wagon-file failed when used by maven-site-plugin
Date Tue, 24 Jan 2006 09:17:07 GMT
    [ http://jira.codehaus.org/browse/WAGON-30?page=comments#action_56746 ] 

Gilles Scokart commented on WAGON-30:
-------------------------------------

For those who followed this issues:

I think it was related to the '.' on linux.

It seems that mkdirs("xx/xx/.") return false on linux, even if the directory is created. 
I guess that that's because the parent directory is first created ("xx/xx"), then the code
tries to create the directory ".", which failed.  But if you check afterward if the directory
exist (what Brett did on his patch), the directory is correctly created.

So, the conclusion is  : never trust the return value of mkdirs !



> wagon-file failed when used by maven-site-plugin
> ------------------------------------------------
>
>          Key: WAGON-30
>          URL: http://jira.codehaus.org/browse/WAGON-30
>      Project: wagon
>         Type: Bug

>     Versions: 1.0-alpha-6
>     Reporter: Gilles Scokart
>     Assignee: Brett Porter
>      Fix For: 1.0-alpha-7
>  Attachments: wagon-file-1.0-alpha-7-SNAPSHOT.jar, wagon-file.patch, wagon-provider-test.patch
>
>
> When maven-site-plugin try a deploy on a file URL, an error is triggered.  This is because
maven-site-plugin call "wagon.putDirectory( inputDirectory, "." );" which fails.
> See http://www.nabble.com/With-maven-2.0.2-site%3Adeploy-doesn%27t-work-t934716.html
> In attachment, you can find a patch adding a test case, and the patch fixing the bug.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: wagon-dev-unsubscribe@maven.apache.org
For additional commands, e-mail: wagon-dev-help@maven.apache.org


Mime
View raw message