From users-return-143912-archive-asf-public=cust-asf.ponee.io@maven.apache.org Tue Mar 19 00:34:13 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0C175180651 for ; Tue, 19 Mar 2019 01:34:12 +0100 (CET) Received: (qmail 84037 invoked by uid 500); 19 Mar 2019 00:34:11 -0000 Mailing-List: contact users-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Users List" Reply-To: "Maven Users List" Delivered-To: mailing list users@maven.apache.org Received: (qmail 84025 invoked by uid 99); 19 Mar 2019 00:34:10 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Mar 2019 00:34:10 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1E290180D5C for ; Tue, 19 Mar 2019 00:34:10 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.048 X-Spam-Level: X-Spam-Status: No, score=0.048 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id aKCPVsa9vYip for ; Tue, 19 Mar 2019 00:34:08 +0000 (UTC) Received: from mail-it1-f182.google.com (mail-it1-f182.google.com [209.85.166.182]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 20A145F544 for ; Tue, 19 Mar 2019 00:26:38 +0000 (UTC) Received: by mail-it1-f182.google.com with SMTP id g17so23411776ita.2 for ; Mon, 18 Mar 2019 17:26:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to; bh=Uq/ub4avWlQnrXg+yhYbejurvTi7ju9P3SFTZG7fkn4=; b=fmDT5z5t9ZN2s0ZtBU3HznIOZqCzhSy0HCjOna+tBkWKZ3wScczkKxueFM12H5S633 YJ/0cQCgkOLhz9dxIGi9ofb2T9XgaCimtsZWk4+9UUgW8QAYkdwB7gZXMzzUXhXrrMM9 XH6woflccw0hry3RsB8QbRpokypHL2Y9gxVsKCx7GvvKowu5LSSC5ST1tVMJpadu+wdx +IoNOXdmvnsYwQdYBO9tAe3CYSuQf/APmGkhwgKwZBmkX1tjkOK/E6T12UvvntB7U9fb 7B8m/P2twu1SIyuzJIaKadnPIRQWsvC41knCNpE561P5U1/Z9lhm+paVlUX6lRaaUkLg zhKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to; bh=Uq/ub4avWlQnrXg+yhYbejurvTi7ju9P3SFTZG7fkn4=; b=cR6IpIs0qy5T0LEVS0f95sscBYopMik3/iA50SAk7Knbwjjdv7A+/V77RjfZjjQ+GP H5BcPNaWFrbN2utQ1frXdYKQoOizsz2JF9Q038DK6rNR0OZM63bie0Ra5/W8waU9mMGW 49hY2UICjQ6vDRtXIGqIV9mVbZtmJdjD3ZulcTQcxF8sUpuAIwceIzSvldIzkuCLpKHe 7Z+q5cwh5jzIERrstKiWJyOhmzV/LZYpZDeo951VjcQvCVAGKe7BqnJmM57xC6pGo0Fk 3guwfos6qUmOC3wyznudO42iXHCqM/bc2bUuGzFr9UeH3bbYg43rxkHVS8mPZBq2BTbE vnkQ== X-Gm-Message-State: APjAAAW0SrQndSfLIZwJzzRGYZbKy3o31nQVvOBkN34mVcNe1P00oflm 0XNE3Z9gvuhAR2eNyoKC+hU= X-Google-Smtp-Source: APXvYqwtniuje/5GzR0Gu8iB+GUpHFLS9MREPP3szBNI4sghAJRsljKHDAQ77G/l3vXAzzwg1jf8ag== X-Received: by 2002:a24:a70c:: with SMTP id a12mr966853itf.74.1552955196886; Mon, 18 Mar 2019 17:26:36 -0700 (PDT) Received: from kyle.internal.gigabyteproductions.net ([2605:a000:f607:ca00:62a4:4cff:fe63:c842]) by smtp.gmail.com with ESMTPSA id l20sm5061515ioj.57.2019.03.18.17.26.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Mar 2019 17:26:35 -0700 (PDT) Subject: Re: Usage of dependency-reduced-pom.xml from maven-shade-plugin in a multi-module/reactor project To: Maven Users List , Francois MAROT References: <1552862296570-0.post@n5.nabble.com> <1552943520558-0.post@n5.nabble.com> From: Kyle Marek Openpgp: preference=signencrypt Autocrypt: addr=psppsn96@gmail.com; prefer-encrypt=mutual; keydata= xsFNBFQvZn8BEADuOd27o11ZNEVlPUyTFY3PxWxB67jIKddBEhVjxbb5A1XGDSHU5jz1tcWN JoGZj86+FP3+twkKv3yKd3jIBqiQwfdghBT9lu6yGPoQgj2ykYqXHV+ru5XWB6D+WpGWDFXY 5x1/5kvpgPRQZGiC3CA+0v8XgK5z1Al/rR7kSmPx1A8DQzEDKVv6NWehCISKwSXlT8mXwVFh vE/Qk/CgPMY6//4UeNSVcuZfvHLE2odg6soRM4wXJ2csD8Sw8XQA/uTExrCAX93EocCG0v6n K1x5iPY6XfZ0BjhBtugXT19LLZx6u/rPwne3zNsk6+rLGgkCPaH7errg6jW1IlqipN2jA1dx GUxObkZjjm1pDe0yGpaAUEJfILN4hVxQQNIya8udSXmqR+aCFNUC+XarqxyTtV2/g9hlSPfk ubnzAKu0u4rPlKKlesEntFuXVrnK99K7patQYHlKvdbA4Am/0utbD0Q5RHOhzViP60b2p4r6 6opKb72ept8DPCcC9myRehfWNAUeAtCURe139HypoSYQhj5whQhc72KjeREnXidWZTmuMsod Uf0cfUnpj/7a8sxVGAH+0uxgMdrSpEzpaY5u/fw2hrC5RAlp470q/FayjwAsER8WVjgxyYVY dLEf4aL8UQ/8FxWOzIO19S52IrtT2CAt9PhaKEo5wzIbUu9umwARAQABzTVLeWxlIE1hcmVr IChHaWdhYnl0ZVByb2R1Y3Rpb25zKSA8cHNwcHNuOTZAZ21haWwuY29tPsLBgQQTAQoAKwIb LwgLCQgHCgQDAgYVCgkICwIFFgIDAQACHgECF4AFAlsojhEFCQjaWw8ACgkQVifmWTvJdDIG 0RAAtcp7/ZdgYpangNtcLgC4QEbtd4kK7T6LdIByFMyrPMkUR2ieiUe9HKp2MK4wPmWJBgE3 yv/RLpmhTwqyRdzfhS6kIBpt0xNeWHQZx/weF9wdfGf+Zuvw929V1tjgdhzDY4NsbxKHkpER DE32FpQIm3YZUC+TkMVyzqMmbt0KC6o/cgT/sswro1141k5OSaKtuoct3mMzFWEG0Dwau9bw hYQ+YNkmnHHKXJbKYxW5lSsI7MP84O07RGnyCJDpHDSA0NOulV9blBqq9nqNcKKOrGVh9GdO MMEbl5EsZtuwxjD3TFYmLIrktFanhQG9+0UDaAuFVBUVc6AgR2FLI1OV12yuIhXp/BxnfGgO F23q5eQIUQQwJTOky0feFrexKgARnU5tL6vyhpmu2xrPujPn0AhzJcz6fLjKPDh3Sc7FDn4s tBlieT6xjuDF7yA7zfr1OstPu61jZWXeZ5Ae0iXk74GQC8T9OnflRM44WanMaox6wVKoani9 UXMiB10fgJSxVO6M6me6Z4dsrZDonf/X1EiLgBBVipCuK5/w1wjytnW2bYfEldHtrzWUUf2d djK0JSyCtKlCmGd3RhFVRXf7MHDcpuPfsBrdao6wnw2G2ISJ+8E2edsXGS2KSSz5wX351Jx7 fy8ZonHjGl+2qnapqs5BTv/NQYIA1jVMqjO2IBXOwU0EVC9ppQEQAMNxrnenMB0zExK2YxUe m0NnMWB+a17nvcVRG1d0k/+WUsm15FrVAVYhgS4wQQJrS5WzPvjHhrKAutpo3BR32XCfl51Q gRf0qU5hytfkeowpmzOJV06RJKhEBhDnl8jgW9FeOvHL5OHugOK+iuTLEU5mM0dN+a56U351 78JcxGr0QrgMTJ0GTKW0tdQ+0E+d9Axkf3dS+BqQwz3zQKUn/AYttiYDqc6X8yobuJEc6sCI gEmVtjT8MqYMFh+p8bA/wj/OuP/TKDKZxGjRsChTudrQwFA5oQIhDJ1Ap9SMBCtTKY8Cd0yw yfQgJALB7MIYzybuo7GGy3pMGehMqU22xdDX9NdGy6DOWoINWtqs8nsDbzOZHrCyPmhFBwXL PL/iRQsJiNMv5mb5GGpshk1ZzjYgON/BBmxieQNCm/vrRZ1hJX0VFGd57hYOdWy9YS2NDqH2 Y/21fhEUngP4AoxJR+2j3bhJG5UlYyVAmUdeDitVDvfWLD9IXfrThSClgurKP1ORExb2hiuJ AZ0JHdBh7mMSJxZQCjru7oySId7xTyfh+QTP1FLqBDLcA7G45xli+D50Ju/QLhkpn521mI49 dbmmukE4MllIu1mRZX0SSEx2c6l7GLooI3cf7GEboR8NUOYQHwzpEmyJ/29rEmux+G9v9EEb EKx8cLBpHwhqPzOXABEBAAHCwWUEGAEKAA8CGwwFAlsojkAFCQjaWBgACgkQVifmWTvJdDLS DxAAs5ojzG5s4m762ce67RH4qIDtxNkCYX6DCBVkxuTdCM01wvAJcCGu8pHw2TZKubA7ZNZ5 ujSF6iOn0tOYaED/eC83yyq3bbnPVWsOzCwu7rztbdXarUh12mFrOOEs9XClMxyg1NHtwTNp vOIv3HNtVf5wtw+cU3Vq7w9Z/+732+q6sv13qNBDmCPUlHIQCPzPvcE3G1rK7kP6xYo/Z9A+ cxB9OZGZuj1on0lFGe+aDeI3GcWym5MQzuEkM68KZLRO5UQC7mT0PyJtRNf9F34w6pIeZZ7G jpOoys/utEApPTDMOf9Ng1Oszirxy9tcqsbC2/AX64R4MGlytUxlKkarF7Ql+qMqPgfRgfiY MKq81CB0Fwf3EQ57YR/kPk6v8Who80NcJRmQvAg9O8kPgXmZNIgdHhz5brKjdOa/eDi0fEJ2 gBpqG0GRyygIYxqu/p72nQWaPXGI6OidL+2go9cIP6tVqTdigLWts2uLt4017L0i6qKAYYnv D6vvFomB1fMr1L0q04Lr3UWdv4fYF4RBxyX4sFu8QSjK5kBqoG8bJEmsGzW6AwEWo2xJ9rNU WiPTA5yG/Xnmy0IKkiELKNPExt+DwENHLqlvUlbpSKJ9v30ggXzWc6NvX4F8/3YVXLo9HeBf sM5UOcgicN2CX6U8GeYu8p+63IRNf+8RDrnHtpo= Message-ID: <3cf78330-7180-0092-b7a2-c346b5334b5e@gmail.com> Date: Mon, 18 Mar 2019 20:26:25 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <1552943520558-0.post@n5.nabble.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QMXHnXAAO4ERPeF8tonKpBYneHYkjxkIT" --QMXHnXAAO4ERPeF8tonKpBYneHYkjxkIT Content-Type: multipart/mixed; boundary="V4QZBHnRIJJVxR3J1xdkRrA3SDQ3NK2jC"; protected-headers="v1" From: Kyle Marek To: Maven Users List , Francois MAROT Message-ID: <3cf78330-7180-0092-b7a2-c346b5334b5e@gmail.com> Subject: Re: Usage of dependency-reduced-pom.xml from maven-shade-plugin in a multi-module/reactor project References: <1552862296570-0.post@n5.nabble.com> <1552943520558-0.post@n5.nabble.com> In-Reply-To: <1552943520558-0.post@n5.nabble.com> --V4QZBHnRIJJVxR3J1xdkRrA3SDQ3NK2jC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: en-US Building the shaded module separately was my workaround for a few days. My current workaround is to specify the intra-module dependency in my parent pom under dependencyManagement with a list of exclusions for the artifacts I am shading into it. Effectively I am manually "reducing" the dependency set of the shaded module as seen from within the multi-module project. However, I think it might be best for Maven to (re-)allow the set of dependencies listed to reduce after build due to plugins like maven-shade-plugin. While needing to shade in general is not ideal, needing to build the module outside of the reactor in addition to shading is less ideal, especially in a larger project where it may need to be ordered between other modules to successfully build. See: https://issues.apache.org/jira/browse/MSHADE-206 See: https://issues.apache.org/jira/browse/MNG-5899 On 3/18/19 5:12 PM, Francois MAROT wrote: > Hi Nikki, > > Regarding your question, I'm not sure of what is a "reactor of reactor"= =2E.. > by 2 separate "projects" I mean 2 different build. Hence 2 different > "reactor". > As I understand it, the reactor is the sum of all Maven modules > participating in the build. Usually in the case of a multi-modules Mave= n > project, you start the build from the top level module, and all your mo= dules > are part of the same rector. Part of the same build. > I personally like to have one git repository per multi-module Maven pro= ject > so we have: > > 1 git repo --> containing one multi-modules Maven project =E2=8A=83 com= posed of many > modules =3D=3D one build =3D=3D one reactor > > What is sure is that for the shade plugin to work, you have to make Mav= en > builds depending on the shaded artifact find this artifact stored in a = repo > (whether local or remote) and not reference it as a module inside the > reactor (ie part of the same build). > > I hope it helps ! --V4QZBHnRIJJVxR3J1xdkRrA3SDQ3NK2jC-- --QMXHnXAAO4ERPeF8tonKpBYneHYkjxkIT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEzwGFU3JoxjgCinBrrOP+4O1Z9H0FAlyQNzEACgkQrOP+4O1Z 9H10yQ//Sycib3koV55gD5B08Ud044bnRqhYakLzezf1XBbPeUQ8RwE2RnW1vY+j nRVv2Gst8DVBsFp6crgyNtUMsyiFDk2FbuGm16FNZwdX93Mts2NAPJd753RUbzOD QhxkP52h0W24CMzip+WHU6Y3vBjQptUL53P2ElbKXm5rzKRI7SLq7Fec0SuMIIK8 ibHf4CVn4kG5xmem2jl2g142UThxroRjv98K7yjI4q0Vmu2ynRKvrjMGYqW3LWnE ym/bQXQShX4dEnTwR2ZBTIX2sedyZcNHXkF17yBQfRDtTnaS76rPn5/FPCoPniaf xpUmQY6Xk+xAXd4uEmGhn40ILmzRci0Vmlzx7/b6/2Tcq64aKC8idTyJubrhIoRi MzEIUzhust44EblasePLMaU38kGuwtA/pfK8bbke7yx2ZT5G952PL8adSBK7Ow+k E3k5KUOUDn8nZb4U9GbFc0hhmjWm8DxTWoktGk18ScR15Z8kovetY0Ll3VPuEmcQ 6ofCjTUbTaoYUwBc00BkY8zWdyKS3TIv/+n4WUT1x9774/qyUu8C6e+JlJXgsNSG gy/NFVLwOEXu5JJtnhEBnYuuTJzBCjZxiY+gQEswRn/vY9yy2MsSgHmOp1RgBqrP HZLMtc0DZToubgtWc82If7HvHoPJbkhVmS3aKRsTSkd2Cbs9bcs= =frIR -----END PGP SIGNATURE----- --QMXHnXAAO4ERPeF8tonKpBYneHYkjxkIT--