Mailing-List: contact users-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Users List" <users@maven.apache.org>
MIME-Version: 1.0
Sender: anders.g.hammar@gmail.com
In-Reply-To: 
 <CAFBiXPq-0+JECCFexo4v5MXjWA+Z7cSG2ymcmw0DDMbB4bcQ1w@mail.gmail.com>
References: 
 <CAFBiXPpS2TC08+ucr=wKWr_iNHnpYBy1s4uWyNx_LNSmpEEdGg@mail.gmail.com>
	<CAKDUN1vL0yqptaxx-66hTgB73cmfEZuMQg3w2n7v8O2Q0b6K=Q@mail.gmail.com>
	<CAFBiXPq-0+JECCFexo4v5MXjWA+Z7cSG2ymcmw0DDMbB4bcQ1w@mail.gmail.com>
Date: Wed, 13 Jan 2016 10:35:13 +0100
Message-ID: 
 <CAKDUN1tBZp=G_Z2kKuakhBQK03CB4ru1WxYJ-pxb5MFq1xsEew@mail.gmail.com>
Subject: Re: Should I disable maven-compiler-plugin when using
 aspectj-maven-compiler?
From: Anders Hammar <anders@hammar.net>
To: Maven Users List <users@maven.apache.org>
Content-Type: multipart/alternative; boundary=001a114a0af41a6650052933e3fb

--001a114a0af41a6650052933e3fb
Content-Type: text/plain; charset=UTF-8

>
> Does this act differently though than the aspectj-maven-plugin? Does it
> play well with AJDT and eclipse?
>

I don't know; I don't use aspectj. Couldn't find any pointers on this in
the aspact-maven-plugin docs so it might be the wrong path. However,
couldn't find any instructions on using your workaround either...:-)
As you stated "aspectj-compiler-plugin" in the subject, I thought that you
wanted to use the aspectj compiler. But maybe I misunderstood and you just
want to weave with aspectj?

/Anders


>
>
> On Wed, Jan 13, 2016 at 10:59 AM, Anders Hammar <anders@hammar.net> wrote:
>
> > Can't you just tell maven-compiler-plugin to use the aspectj compiler?
> >
> >
> https://maven.apache.org/plugins/maven-compiler-plugin/non-javac-compilers.html
> >
> > /Anders
> >
> > On Wed, Jan 13, 2016 at 9:41 AM, Dagan Sandler <dagansandler@gmail.com>
> > wrote:
> >
> > > Hi,
> > >
> > > I am in the process of updating my plugin definitions in all of the
> > > projects I manage.
> > > Notably, I tried updating maven-compiler-plugin from 2.5.1 to 3.3 but
> > > encountered an issue in a project that uses aspectj-maven-plugin.
> > >
> > > The issue is, it seems, that the maven-compiler-plugin is invoked
> before
> > > the aspectj-maven-plugin, and causes the build to fail.
> > >
> > > I have previously used a workaround for this issue by setting the
> > > aspectj-maven-plugin to execute in phase process-sources, so it's
> invoked
> > > before the maven plugin
> > > However, in maven-compiler-plugin 3.1+ there's this bug
> > > <https://issues.apache.org/jira/browse/MCOMPILER-209> which causes the
> > > maven-compiler-plugin to recompile all sources and to fail the build,
> so
> > > you must set useIncrementalCompilation to *false*
> > >
> > > Another workaround I found before finding out about the incremental
> build
> > > bug, is to disable the maven-compiler-plugin altogether in that project
> > and
> > > let aspectj-maven-plugin do all the compilation by adding
> > > <execution>
> > > <id>default-compile</id>
> > > <phase>none</phase>
> > > </execution>
> > > to the maven-compiler-plugin definition
> > >
> > > Anyone knows the downsides of any of these workarounds? Is there
> another
> > > configuration that I should be using instead of these options?
> > >
> >
>

--001a114a0af41a6650052933e3fb--