Mailing-List: contact users-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Users List" <users@maven.apache.org>
From: Johannes Ernst <johannes.ernst@gmail.com>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_D2516A6E-1E29-4507-A0A2-00D80F139A7D"
Subject: [WARNING] Configuration options: 'appendAssemblyId' is set to false,
 and 'classifier' is missing.
Message-Id: <09F6DDAD-48C7-4CFB-9B62-9A012904AF31@gmail.com>
Date: Sat, 9 May 2015 17:03:27 -0700
To: users@maven.apache.org
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))

--Apple-Mail=_D2516A6E-1E29-4507-A0A2-00D80F139A7D
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

A couple of days I asked about how to =E2=80=9Croll up=E2=80=9D several =
maven projects into a new one, as if the old ones had never existed. =
Didn=E2=80=99t get a reply though.

Reviewing the source code for AbstractAssemblyMojo, I found that if I =
set

    appendAssemblyId=3Dfalse

(default is true, and this @Parameter does not seem to be documented on =
the website), I get the behavior I want.

Plus the above warning. Here it is in its full glory:

    [WARNING] Configuration options: 'appendAssemblyId' is set to false, =
and 'classifier' is missing.
    Instead of attaching the assembly file: xxx.jar, it will become the =
file for main project artifact.
    NOTE: If multiple descriptors or descriptor-formats are provided for =
this project, the value of this file will be non-deterministic!

Which in my case, is entirely unnecessary because I only have one. And I =
think my use of the plugin is useful :-)

Can I suggest the following modification of the code, in =
AbstractAssemblyMojo.execute()

    <strike> boolean warnedAboutMainProjectArtifact =3D false;
    <insert> int numberMainArtifactReplacers =3D 0;

    for ( final Assembly assembly : assemblies )
    {
        =E2=80=A6
        for ( final String format : effectiveFormats )
            =E2=80=A6
            =E2=80=A6 (long if-then-else)
            else if ( !"pom".equals( type ) && format.equals( type ) )
            {
                <strike> if ( !warnedAboutMainProjectArtifact )
                <insert> if( numberMainArtifactReplacers > 1 )=20
                {
                    =E2=80=A6 emit above warning

                    <strike>warnedAboutMainProjectArtifact =3D true;
                    <insert>++ numberMainArtifactReplacers;

and perhaps, upgrade the warning to an error because it now only gets =
emitted if there indeed will be a conflict.

And some documentation on the website that says this can be done.

Now, shoot, and tell me what this is a bad idea! :-)=20

Cheers,


Johannes.


Johannes Ernst
Blog: http://upon2020.com/ <http://upon2020.com/>
Twitter: @Johannes_Ernst
GPG key: http://upon2020.com/public/pubkey.txt =
<http://upon2020.com/public/pubkey.txt>
Check out UBOS, the Linux distro for personal servers: http://ubos.net/ =
<http://ubos.net/>


--Apple-Mail=_D2516A6E-1E29-4507-A0A2-00D80F139A7D--