maven-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stuart McCulloch <mccu...@gmail.com>
Subject Re: is the "wagon-maven-plugin" broken?
Date Mon, 16 Dec 2013 17:38:13 GMT
Looks like a shading issue in maven-wagon/wagon-providers/wagon-http:

	https://git-wip-us.apache.org/repos/asf?p=maven-wagon.git;a=blob;f=wagon-providers/wagon-http/pom.xml;h=1fd61e34da435024062a566f6bd68410d98fdc67;hb=HEAD#l87

It doesn’t shade in commons-io, commons-lang, or jsoup; despite wagon-http-shared switching
from plexus-utils to commons-lang/io, and over to jsoup as the HTML parser:

	https://git-wip-us.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=ec65719a
	https://git-wip-us.apache.org/repos/asf?p=maven-wagon.git;a=commit;h=02681881

	[INFO] --- maven-shade-plugin:1.4:shade (default) @ wagon-http ---
	[INFO] Excluding org.apache.maven.wagon:wagon-http-shared:jar:2.6-SNAPSHOT from the shaded
jar.
	[INFO] Excluding org.jsoup:jsoup:jar:1.7.2 from the shaded jar.
	[INFO] Excluding commons-lang:commons-lang:jar:2.6 from the shaded jar.
	[INFO] Excluding commons-io:commons-io:jar:2.2 from the shaded jar.
	[INFO] Including org.apache.httpcomponents:httpclient:jar:4.3.1 in the shaded jar.
	[INFO] Including commons-codec:commons-codec:jar:1.6 in the shaded jar.
	[INFO] Including commons-logging:commons-logging:jar:1.1.3 in the shaded jar.
	[INFO] Including org.apache.httpcomponents:httpcore:jar:4.3 in the shaded jar.
	[INFO] Excluding org.apache.maven.wagon:wagon-provider-api:jar:2.6-SNAPSHOT from the shaded
jar.
	[INFO] Excluding org.codehaus.plexus:plexus-utils:jar:3.0.8 from the shaded jar.
	[INFO] Attaching shaded artefact.

It might be less fragile to just exclude unwanted dependencies in the wagon-http shade configuration,
rather than have to keep the list of includes in sync?

As to why the IT passes with M2 but fails with M3... wagon-http is included in the distribution
lib (uber jar for M2, separate jar for M3) so M2 is using an older version of wagon that doesn’t
suffer from the above issue.

On 16 Dec 2013, at 16:28, Dan Tran <dantran@gmail.com> wrote:

> fails with mvn 3 and works with mvn2 :(
> 
> On Sun, Dec 15, 2013 at 11:11 PM, Sankaran, Nambi <nsankaran@ebay.com>wrote:
> 
>> Please try the integration tests from the http-download
>> 
>> https://svn.codehaus.org/mojo/trunk/mojo/wagon-maven-plugin/src/it/http-download/
>> 
>> 
>> -----Original Message-----
>> From: Dan Tran [mailto:dantran@gmail.com]
>> Sent: Sunday, December 15, 2013 11:09 PM
>> To: Maven Users List
>> Subject: Re: is the "wagon-maven-plugin" broken?
>> 
>> got  small pom to reproduce this issue? does it work with maven 2?
>> 
>> -D
>> 
>> 
>> On Sun, Dec 15, 2013 at 9:32 PM, Sankaran, Nambi <nsankaran@ebay.com>
>> wrote:
>> 
>>> None of the goals in “wagon-maven-plugin” work
>>> http://mojo.codehaus.org/wagon-maven-plugin/plugin-info.html
>>> 
>>> Have anyone used any of these goals before?
>>> 
>>> https://svn.codehaus.org/mojo/trunk/mojo/wagon-maven-plugin/src/it/htt
>>> p-download/pom.xml
>>> 
>>> [INFO] Scanning for projects...
>>> [WARNING]
>>> [WARNING] Some problems were encountered while building the effective
>>> model for org.codehaus.mojo:wagon-maven-plugin:pom:testing
>>> [WARNING] 'build.plugins.plugin.version' for
>>> org.codehaus.mojo:wagon-maven-plugin is missing. @ line 16, column 21
>>> [WARNING] [WARNING] It is highly recommended to fix these problems
>>> because they threaten the stability of your build.
>>> [WARNING]
>>> [WARNING] For this reason, future Maven versions might no longer
>>> support building such malformed projects.
>>> [WARNING]
>>> [INFO]
>>> [INFO]
>>> ----------------------------------------------------------------------
>>> -- [INFO] Building wagon-maven-plugin testing [INFO]
>>> ----------------------------------------------------------------------
>>> --
>>> [INFO]
>>> [INFO] --- wagon-maven-plugin:1.0-beta-4:list (http-list) @
>>> wagon-maven-plugin --- [INFO] Scanning remote file system:
>>> http://repo1.maven.org/maven2/commons-dbutils/commons-dbutils ...
>>> [INFO]
>>> ----------------------------------------------------------------------
>>> --
>>> [INFO] BUILD FAILURE
>>> [INFO]
>>> ----------------------------------------------------------------------
>>> --
>>> [INFO] Total time: 7.598s
>>> [INFO] Finished at: Sun Dec 15 21:29:01 PST 2013 [INFO] Final Memory:
>>> 6M/123M [INFO]
>>> ----------------------------------------------------------------------
>>> --
>>> [ERROR] Failed to execute goal
>>> org.codehaus.mojo:wagon-maven-plugin:1.0-beta-4:list (http-list) on
>>> project
>>> wagon-maven-plugin: Execution http-list of goal
>>> org.codehaus.mojo:wagon-maven-plugin:1.0-beta-4:list failed: A
>>> required class was missing while executing
>>> org.codehaus.mojo:wagon-maven-plugin:1.0-beta-4:list:
>>> org/apache/commons/io/IOUtils
>>> [ERROR] -----------------------------------------------------
>>> [ERROR] realm =    plugin>org.codehaus.mojo:wagon-maven-plugin:1.0-beta-4
>>> [ERROR] strategy =
>>> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
>>> [ERROR] urls[0] =
>>> file:/Users/nsankaran/.m2/raptor2/org/codehaus/mojo/wagon-maven-plugin
>>> /1.0-beta-4/wagon-maven-plugin-1.0-beta-4.jar
>>> [ERROR] urls[1] =
>>> file:/Users/nsankaran/.m2/raptor2/org/codehaus/plexus/plexus-utils/1.5
>>> .6/plexus-utils-1.5.6.jar
>>> [ERROR] urls[2] =
>>> file:/Users/nsankaran/.m2/raptor2/org/apache/maven/shared/file-managem
>>> ent/1.2.1/file-management-1.2.1.jar
>>> [ERROR] urls[3] =
>>> file:/Users/nsankaran/.m2/raptor2/org/apache/maven/shared/maven-shared
>>> -io/1.1/maven-shared-io-1.1.jar
>>> [ERROR] Number of foreign imports: 1
>>> [ERROR] import: Entry[import  from realm ClassRealm[maven.api, parent:
>>> null]]
>>> [ERROR]
>>> [ERROR] -----------------------------------------------------:
>>> org.apache.commons.io.IOUtils
>>> [ERROR] -> [Help 1]
>>> [ERROR]
>>> [ERROR] To see the full stack trace of the errors, re-run Maven with
>>> the -e switch.
>>> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
>>> [ERROR]
>>> [ERROR] For more information about the errors and possible solutions,
>>> please read the following articles:
>>> [ERROR] [Help 1]
>>> http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerExcept
>>> ion
>>> 
>>> 
>> 


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Mime
View raw message