maven-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Derricutt <m...@talios.com>
Subject Re: maven-release-plugin oddity - no git commit under mvn 3.1.1
Date Mon, 09 Dec 2013 04:23:48 GMT
Ok - so this looks to be an issue introduced in Git 1.8.5, from
https://raw.github.com/git/git/master/Documentation/RelNotes/1.8.5.txt

 * "git status" now omits the prefix to make its output a comment in a
   commit log editor, which is not necessary for human consumption.
   Scripts that parse the output of "git status" are advised to use
   "git status --porcelain" instead, as its format is stable and easier
   to parse.

>From looking at the git log of
./maven-scm-providers/maven-scm-providers-git/maven-scm-provider-gitexe/src/main/java/org/apache/maven/scm/provider/git/gitexe/command/status/GitStatusConsumer.java
I see that the has been using the newer "git status --porcelain" command
for some time now, however from walking the dependencies of
maven-release-plugin, I appear to find 1.7 being resolved ( at least via
IntellliJ ).

It looks like Olivier Lamy updated the "git status" support in [1] in git
commit 5c58908896a1b82bc6ee0af005adf0d6ef326395

Up until this week this didn't appear to be a problem, until Git 1.8.5 was
released and removed the leading # from the status messages....

How do we get Maven to start using the newer releases of SCM - is that just
a matter of declaring a dependency in my parent pom?

Mark



[1] [SCM-686] Maven SCM failed to parse "git status" output if git messages
are translated - Submitted by Ralf Thielow.

-- 
"Great artists are extremely selfish and arrogant things" — Steven Wilson,
Porcupine Tree


On Mon, Dec 9, 2013 at 3:40 PM, Mark Derricutt <mark@talios.com> wrote:

> Hey all,
>
> Just encountered a strange issue with the maven-release-plugin, when doing
> a release:prepare from my machine using Maven 3.1.1, and
> maven-release-plugin 2.4.2 I get the following output:
>
> [INFO] Checking in modified POMs...
> [INFO] Executing: /bin/sh -c cd
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation && git add
> -- pom.xml
> [INFO] Working directory:
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation
> [INFO] Executing: /bin/sh -c cd
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation && git
> status
> [INFO] Working directory:
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation
> [INFO] Tagging release with the label com.smxemail.translation-13.2.9...
> [INFO] Executing: /bin/sh -c cd
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation && git tag
> -F
> /var/folders/bq/jtxn4t511xz7l_t3t4q4c6340000gn/T/maven-scm-596385603.commit
> com.smxemail.translation-13.2.9
> [INFO] Working directory:
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation
> [INFO] Executing: /bin/sh -c cd
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation && git
> ls-files
> [INFO] Working directory:
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation
> [INFO] Transforming 'com.smxemail.translation'...
> [INFO] Not removing release POMs
> [INFO] Checking in modified POMs...
> [INFO] Executing: /bin/sh -c cd
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation && git add
> -- pom.xml
> [INFO] Working directory:
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation
> [INFO] Executing: /bin/sh -c cd
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation && git
> status
> [INFO] Working directory:
> /Users/amrk/IdeaProjects/securemx/smx3/com.smxemail.translation
> [INFO] Release preparation complete.
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
>
> You can see here that there are no "git commit" commands being run, this
> in turn breaks the build.
>
> A coworker who is still using Maven 3.0.4 was able to prepare and release
> the artefact fine however, so I'm wondering if there's some issue at the
> SCM layer of maven that's breaking when running under 3.1.1 that isn't an
> issue when using 3.0.4.
>
> Has anyone else seen any behaviour like this?
>
> Mark
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message