maven-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: Release plugin to check SCM location
Date Tue, 28 Sep 2010 13:56:22 GMT
It sounds like you're on the right track - you're correct, that it would
need to go into the validation logic of maven-scm (though not necessarily
the maven-scm-plugin).

2010/9/28 Lóránt Pintér <lorant.pinter@gmail.com>

> I'd be willing to do this, but I have no clue what to change.
>
> Should this check be part of the SCM plugin itself, like part of the
> validate goal, or maybe a new goal? In this case, I'd need to add something
> like ScmProvider.getUrl(ScmRepository repository, String rootPath); That
> means that all SCM providers would need to be updated.
>
> Or shall I add this only for the Subversion provider(s)? In that case,
> there
> is an ScmProvider.validateScmUrl() method, but it doesn't know about the
> location of the working copy. So, again, another method should be added
> like
> ScmProvider.validateScmUrlAgainstWorkingCopy(String scmUrl, ScmRepository
> repository, String rootPath);, and it would require a change in all SCM
> providers again.
>
> Lóránt
>
> On Tue, Sep 28, 2010 at 09:04, Brett Porter <brett@apache.org> wrote:
>
> >
> > On 28/09/2010, at 4:01 PM, Lóránt Pintér wrote:
> >
> > > My problem with both these options is that they'd only check the syntax
> > of
> > > the URLs. My problem is more like
> > > "MRELEASE-494<http://jira.codehaus.org/browse/MRELEASE-494>:
> > > Should fail during release:prepare if scm:url doesn't match working
> > copy".
> >
> > Ok, they should be part of one check, but I can see why they might be
> > implemented separately.
> >
> > > Is there a plugin/goal/way to check this, at least before the release?
> >
> > None that I know of - I'm sure it's not too hard to implement though if
> > you'd like to take a shot at a patch!
> >
> > Cheers,
> > Brett
> >
> > --
> > Brett Porter
> > brett@apache.org
> > http://brettporter.wordpress.com/
> >
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > For additional commands, e-mail: users-help@maven.apache.org
> >
> >
>



-- 
Brett Porter
http://brettporter.wordpress.com/

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message