Return-Path: Delivered-To: apmail-maven-surefire-commits-archive@www.apache.org Received: (qmail 51033 invoked from network); 9 Mar 2008 00:27:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Mar 2008 00:27:56 -0000 Received: (qmail 10912 invoked by uid 500); 9 Mar 2008 00:27:53 -0000 Delivered-To: apmail-maven-surefire-commits-archive@maven.apache.org Received: (qmail 10864 invoked by uid 500); 9 Mar 2008 00:27:53 -0000 Mailing-List: contact surefire-commits-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: surefire-dev@maven.apache.org Delivered-To: mailing list surefire-commits@maven.apache.org Delivered-To: moderator for surefire-commits@maven.apache.org Received: (qmail 53962 invoked by uid 99); 8 Mar 2008 18:02:32 -0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: svn commit: r635029 - /maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java Date: Sat, 08 Mar 2008 18:02:14 -0000 To: surefire-commits@maven.apache.org From: hboutemy@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080308180215.07DE41A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: hboutemy Date: Sat Mar 8 10:02:13 2008 New Revision: 635029 URL: http://svn.apache.org/viewvc?rev=635029&view=rev Log: [SUREFIRE-440] Fix serialization of File[] into properties for forked Surefire run Submitted by: Benjamin Bentmann Reviewed by: Hervé Boutemy changed to StringUtils.join API instead of the original code fix Modified: maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java Modified: maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java URL: http://svn.apache.org/viewvc/maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java?rev=635029&r1=635028&r2=635029&view=diff ============================================================================== --- maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java (original) +++ maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java Sat Mar 8 10:02:13 2008 @@ -570,17 +570,8 @@ { if ( param instanceof File[] ) { - String s = "["; - File[] f = (File[]) param; - for ( int i = 0; i < f.length; i++ ) - { - s += f[i]; - if ( i > 0 ) - { - s += ","; - } - } - return s + "]"; + File[] files = (File[]) param; + return "[" + StringUtils.join( files, "," ) + "]"; } else if ( param instanceof Properties ) { ByteArrayOutputStream baos = new ByteArrayOutputStream(); try