maven-surefire-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hbout...@apache.org
Subject svn commit: r635029 - /maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java
Date Sat, 08 Mar 2008 18:02:14 GMT
Author: hboutemy
Date: Sat Mar  8 10:02:13 2008
New Revision: 635029

URL: http://svn.apache.org/viewvc?rev=635029&view=rev
Log:
[SUREFIRE-440] Fix serialization of File[] into properties for forked Surefire run
Submitted by: Benjamin Bentmann
Reviewed by: Hervé Boutemy

changed to StringUtils.join API instead of the original code fix

Modified:
    maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java

Modified: maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java
URL: http://svn.apache.org/viewvc/maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java?rev=635029&r1=635028&r2=635029&view=diff
==============================================================================
--- maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java
(original)
+++ maven/surefire/trunk/surefire-booter/src/main/java/org/apache/maven/surefire/booter/SurefireBooter.java
Sat Mar  8 10:02:13 2008
@@ -570,17 +570,8 @@
     {
         if ( param instanceof File[] )
         {
-            String s = "[";
-            File[] f = (File[]) param;
-            for ( int i = 0; i < f.length; i++ )
-            {
-                s += f[i];
-                if ( i > 0 )
-                {
-                    s += ",";
-                }
-            }
-            return s + "]";
+            File[] files = (File[]) param;
+            return "[" + StringUtils.join( files, "," ) + "]";
         } else if ( param instanceof Properties ) {
             ByteArrayOutputStream baos = new ByteArrayOutputStream();
             try



Mime
View raw message