maven-scm-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Mackinlay" <p...@webotech.co.uk>
Subject Re: mark files for deletion with perforce
Date Wed, 06 Apr 2011 13:52:23 GMT
Thanks - jira with attached patch raised here:
http://jira.codehaus.org/browse/SCM-615 

Paul
 --
Paul Mackinlay
http://www.webotech.co.uk/ 

Olivier Lamy writes: 

> Yup create a patch and attach it to a new issue :
> http://jira.codehaus.org/browse/SCM 
> 
> A good starting point is here [1] or [2] 
> 
> Thanks
> --
> Olivier 
> 
> [1] http://maven.apache.org/guides/development/guide-helping.html
> [2] http://maven.apache.org/guides/development/guide-m2-development.html#Creating_and_submitting_a_patch

> 
> 
> 2011/4/6 Paul Mackinlay <paul@webotech.co.uk>:
>> I have created a RemoveMojo and have run tests locally to check that it
>> works as expected.
>> How do I apply for a developer account so check in the code? Do I just raise
>> a ticket here:
>> http://jira.codehaus.org/browse/SCM
>> Also while testing the RemoveMojo I discovered that
>> PerforceRemoveCommand.executeRemoveCommand() swallows CommandLineException.
>> Surely it should rethrow it as an ScmException. Now when a "p4 delete"
>> command fails the result object returned by ScmManager will have isSuccess()
>> equal to true. Ultimately I think this means that when marking a resource as
>> deleted fails it won't fail a maven build.
>> Thanks,
>> Paul
>> --
>> Paul Mackinlay
>> http://www.webotech.co.uk/ 
>>
>  
> 
> 
> -- 
> Olivier Lamy
> http://twitter.com/olamy
> http://www.linkedin.com/in/olamy
 


Mime
View raw message