Return-Path: Delivered-To: apmail-maven-m2-dev-archive@www.apache.org Received: (qmail 10346 invoked from network); 12 Sep 2004 15:50:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 12 Sep 2004 15:50:43 -0000 Received: (qmail 98669 invoked by uid 500); 12 Sep 2004 15:50:43 -0000 Delivered-To: apmail-maven-m2-dev-archive@maven.apache.org Received: (qmail 98620 invoked by uid 500); 12 Sep 2004 15:50:42 -0000 Mailing-List: contact m2-dev-help@maven.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: List-Id: "Maven 2 Developers List" Reply-To: "Maven 2 Developers List" Delivered-To: mailing list m2-dev@maven.apache.org Received: (qmail 98605 invoked by uid 99); 12 Sep 2004 15:50:42 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from [66.216.68.111] (HELO hogshead.codehaus.org) (66.216.68.111) by apache.org (qpsmtpd/0.28) with ESMTP; Sun, 12 Sep 2004 08:50:40 -0700 Received: from [192.168.1.105] (CPE00045a0b555b-CM023080004191.cpe.net.cable.rogers.com [24.102.210.93]) by hogshead.codehaus.org (8.11.6/8.11.6) with ESMTP id i8CGKm328187 for ; Sun, 12 Sep 2004 11:20:48 -0500 Subject: Re: ognl WAS: cvs commit: maven-components/maven-core/src/main/java/org/apache/maven/plugin OgnlProjectValueExtractor.java From: Jason van Zyl To: Maven 2 Developers List In-Reply-To: <003e01c498bd$a0958190$0200a8c0@cgeyfr.cgey.fr> References: <20040911121619.61423.qmail@minotaur.apache.org> <1094944407.41438697b2519@postoffice.tpg.com.au> <003e01c498bd$a0958190$0200a8c0@cgeyfr.cgey.fr> Content-Type: text/plain Organization: Message-Id: <1095004232.5194.94.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) Date: 12 Sep 2004 11:50:32 -0400 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N On Sun, 2004-09-12 at 07:42, Emmanuel Venisse wrote: > I make this little change for run the doxia plugin, but I don't like > basedir/* property. > For the doxia plugin, I think we should add a siteDirectory in the build pom > part and remove my changes. Some form of site element in the POM is a great idea. I don't think it belongs in the build section though. I am deploying the site using elements in but we could probably do with a element to encapsulate all things related to the site. I honestly thing #basedir could eventually go away entirely, we should have standard places for everything. What maven produces and uses is boundless but we certainly can have standard top-level directories for anything produced. Using #basedir is admittedly a bad idea. > > > > Perhaps we should change this whole handler such that we check # first to > see if > > it is an expression. If so we next split it on / if it exists and keep the > path > > element, then do the expression handling. We would also need to evaluate > the > > path as an expression in case there are subexpressions. > > > > What do you think? > > Sure, do you want to fix it? Let's get rid of the use of #basedir, when we then encounter a short-coming we can adjust for it instead of adding more hacks. -- jvz. Jason van Zyl jason@maven.org http://maven.apache.org happiness is like a butterfly: the more you chase it, the more it will elude you, but if you turn your attention to other things, it will come and sit softly on your shoulder ... -- Thoreau