Mailing-List: contact m2-dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven 2 Developers List" <m2-dev@maven.apache.org>
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <004a01c4a7ae$a4bacc30$398c440a@cgeyfr.cgey.fr>
From: "Emmanuel Venisse" <emmanuel@venisse.net>
To: "Maven 2 Developers List" <m2-dev@maven.apache.org>
References: <DF7EC83D7AFBD411965B0008C7596EC50199027D@imtfexchange.imtf.ch>
Subject: Re: cvs commit:
 maven-components/maven-core/src/main/java/org/apache/maven/lifecycle/goal/phase
 GoalAttainmentPhase.java
Date: Fri, 1 Oct 2004 14:03:18 +0200
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: 7bit


----- Original Message ----- 
From: "Maczka Michal" <michal.maczka@imtf.ch>
To: "'Maven 2 Developers List'" <m2-dev@maven.apache.org>
Sent: Friday, October 01, 2004 10:44 AM
Subject: RE: cvs commit:
maven-components/maven-core/src/main/java/org/apache/maven/lifecycle/goal/ph
ase GoalAttainmentPhase.java


>
> >   +    private String createPluginParameterRequiredMessage(
> > MojoDescriptor mojo, Parameter parameter )
> >   +    {
> >   +        StringBuffer message = new StringBuffer();
> >   +
> >   +        message.append( "The " + parameter.getName() ).
> >   +                append( " is required for the execution of the " ).
> >   +                append( mojo.getId() ).
> >   +                append( " mojo and cannot be null." );
> >   +
> >   +        return message.toString();
> >        }
> Jason!
>
> Any particular reason why are you using StringBuffers for such tasks? Is
it
> question of the style?
>
> AFAIK this will result of such code in exactly the same
> as:
>
>
> String message = "The " + parameter.getName() + " is required for the
> execution of the "  + mojo.getId() + " mojo and cannot be null." );
>
>
> I mean that byteycode & performance is identical

Yes for the Sun jdk, but it isn't the case for all bytecode generator.

>
> If I remember it is mentioned in JLS   and described in "effective java".

I think it's only a recommandation. If a generator doesn't use the
stringbuffer model, it's a correct bytecode but not optimized.

>
> StringBuffers are normally recommended if you need to use loops for
> constructing messages.
>
> I personally always use second form - but this is really the question of
> style - that's why I am asking if this is a style which you prefer?
>
>
> Michal
>