From issues-return-189140-archive-asf-public=cust-asf.ponee.io@maven.apache.org Fri Jul 23 13:33:34 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id B065E180654 for ; Fri, 23 Jul 2021 15:33:34 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id E083046306 for ; Fri, 23 Jul 2021 13:33:33 +0000 (UTC) Received: (qmail 30072 invoked by uid 500); 23 Jul 2021 13:33:33 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 30055 invoked by uid 99); 23 Jul 2021 13:33:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jul 2021 13:33:33 +0000 From: =?utf-8?q?GitBox?= To: issues@maven.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bmaven-pmd-plugin=5D_adangel_commented_on_a_change_?= =?utf-8?q?in_pull_request_=2344=3A_=5BMPMD-318=5D_Fix_the_aux_classpath_whe?= =?utf-8?q?n_includeTests_is_set_to_true?= Message-ID: <162704721320.16310.18295068971404756408.asfpy@gitbox.apache.org> Date: Fri, 23 Jul 2021 13:33:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: adangel commented on a change in pull request #44: URL: https://github.com/apache/maven-pmd-plugin/pull/44#discussion_r675568103 ########## File path: src/main/java/org/apache/maven/plugins/pmd/PmdReport.java ########## @@ -561,7 +563,7 @@ private String determineAuxClasspath() throws MavenReportException } TransformableFilter filter = new AndFilter( Arrays.asList( new ExclusionsFilter( exclusionPatterns ), - includeTests ? ScopeFilter.including( "test" ) : ScopeFilter.including( "compile" ) + includeTests ? ScopeFilter.including( "compile", "test" ) : ScopeFilter.including( "compile" ) Review comment: The missing provided scope might explain https://issues.apache.org/jira/browse/MPMD-317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org