maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-pmd-plugin] adangel commented on a change in pull request #44: [MPMD-318] Fix the aux classpath when includeTests is set to true
Date Fri, 23 Jul 2021 13:33:33 GMT

adangel commented on a change in pull request #44:
URL: https://github.com/apache/maven-pmd-plugin/pull/44#discussion_r675568103



##########
File path: src/main/java/org/apache/maven/plugins/pmd/PmdReport.java
##########
@@ -561,7 +563,7 @@ private String determineAuxClasspath() throws MavenReportException
                 }
                 TransformableFilter filter = new AndFilter( Arrays.asList(
                         new ExclusionsFilter( exclusionPatterns ),
-                        includeTests ? ScopeFilter.including( "test" ) : ScopeFilter.including(
"compile" )
+                        includeTests ? ScopeFilter.including( "compile", "test" ) : ScopeFilter.including(
"compile" )

Review comment:
       The missing provided scope might explain https://issues.apache.org/jira/browse/MPMD-317




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message