From issues-return-187149-archive-asf-public=cust-asf.ponee.io@maven.apache.org Fri Jun 18 21:21:46 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 6ACD118064E for ; Fri, 18 Jun 2021 23:21:46 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 63141447F4 for ; Fri, 18 Jun 2021 21:21:11 +0000 (UTC) Received: (qmail 5518 invoked by uid 500); 18 Jun 2021 21:21:11 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 5506 invoked by uid 99); 18 Jun 2021 21:21:11 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Jun 2021 21:21:11 +0000 From: =?utf-8?q?GitBox?= To: issues@maven.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bmaven-shade-plugin=5D_nielsbasjes_commented_on_a_c?= =?utf-8?q?hange_in_pull_request_=2325=3A_=5BMSHADE-36=5D_Use_reduced_depend?= =?utf-8?q?encies?= Message-ID: <162405127105.22855.10681434667258122204.asfpy@gitbox.apache.org> Date: Fri, 18 Jun 2021 21:21:11 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: nielsbasjes commented on a change in pull request #25: URL: https://github.com/apache/maven-shade-plugin/pull/25#discussion_r653856204 ########## File path: src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java ########## @@ -285,6 +286,14 @@ @Parameter( defaultValue = "false" ) private boolean generateUniqueDependencyReducedPom; + /** + * Add dependency reduced POM to the JAR instead of the original one provided by the project. Review comment: LOL, I was just about to push the same change :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org