maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Nord (Jira)" <j...@apache.org>
Subject [jira] [Commented] (MRELEASE-899) release:prepare should not change the line separator but detect effective line separator from pom.xml
Date Fri, 04 Dec 2020 10:58:00 GMT

    [ https://issues.apache.org/jira/browse/MRELEASE-899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243935#comment-17243935
] 

James Nord commented on MRELEASE-899:
-------------------------------------

>> Can you explain why this chaos is desired: my SCM is *properly *configured to check-out
"as is" and check-in "as is".
> Why has this turned into a meta discussion? 

I completely agree, however I will indulge in a 30,000ft view...

I use windows and Linux on the same machine at the same time - Windows has this thing called
WSL (and WSL2).  I also use docker on windows, because that's a thing to).  Some tools on
these Linux environments do not work too well with windows line feeds.  
The code I have checked out I often run Linux CLI tools on them, I also often checkout and
work in Eclipse on windows and maybe run the code in Linux (from the same local filesystem
(albeit via a local CIFS mount - but we digress).  I often also build the code in Linux with
a Linux JVM so I can run the tests on Linux as well as windows (because Java is not portable!).
in general windows tools can cope with Linux line ends much better than Linux ones.  
Also to note is that I have some files that are test files in some projects that trigger a
bug *only* when they are using windows line endings, or only when using Linux line endings
(due to a quirk in some parser somewhere). 

so basically *my* workflow involves just knowing that all my tooling will use whatever is
in the repository that I am cloning.

Yes I can could do things slightly differently but I know the limitations of my workflow,
as well as all the advantages.

 

> release:prepare should not change the line separator but detect effective line separator
from pom.xml
> -----------------------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-899
>                 URL: https://issues.apache.org/jira/browse/MRELEASE-899
>             Project: Maven Release Plugin
>          Issue Type: Improvement
>            Reporter: Ralph van Etten
>            Priority: Major
>
> Currently the plugin use the system property {{line.separator}} when it rewrites the
pom.xml.
> This causes trouble, because every line in changed, when a project is released sometimes
under Windows and sometimes under Linux (because of its different line separators). (http://stackoverflow.com/questions/11868590/maven-release-plugin-and-windows-line-breaks)
> Therefore it would be a nice feature when the plugin would not use the systems line separator
but the line separator that is already used in the pom.xml.
> On the other hand, changing the existing behaviour would maybe, also harm someone else.
> Therefore it would be an great feature when there would be an property that define the
expected behaviour, maybe in the same way it is done by the maven-assembly-plugin's property
fileSet.lineEnding (http://maven.apache.org/plugins/maven-assembly-plugin/component.html#class_fileSet)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message