maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven] rfscholte commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments
Date Fri, 30 Oct 2020 09:06:23 GMT

rfscholte commented on a change in pull request #386:
URL: https://github.com/apache/maven/pull/386#discussion_r514956563



##########
File path: maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java
##########
@@ -249,9 +249,9 @@ public void testReadInvalidPom()
         catch ( ProjectBuildingException ex )
         {
             assertEquals( 1, ex.getResults().size() );
-            MavenProject project = ex.getResults().get( 0 ).getProject();
-            assertNotNull( project );
-            assertNotSame( 0, ex.getResults().get( 0 ).getProblems().size() );
+            assertNotNull( ex.getResults().get( 0 ).getPomFile() );

Review comment:
       Noted. Now that we are using Java 8 it should be quite to catch these leaks by using
assertThrows. If you hit such a test class, just fix it as part of continuous maintenance.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message