maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-ear-plugin] elharo commented on a change in pull request #17: [MEAR-287] Fixed failure when destination directory exists
Date Sat, 03 Oct 2020 15:57:15 GMT

elharo commented on a change in pull request #17:
URL: https://github.com/apache/maven-ear-plugin/pull/17#discussion_r499159371



##########
File path: src/test/java/org/apache/maven/plugins/ear/it/EarMojoIT.java
##########
@@ -993,4 +993,24 @@ public void testProject087()
     {
         doTestProject( "project-087", new String[] { "eartest-ejb-sample-one-1.0.jar", "eartest-ejb-sample-two-1.0.jar"
} );
     }
+
+    /**
+     * Builds WAR and EAR as part of multi-module project twice so that the 2nd build is
guaranteed to be performed when
+     * target directories and files exist.
+     * @throws Exception in case of an error.

Review comment:
       We don't need to be consistent with mistakes. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message