maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (Jira)" <j...@apache.org>
Subject [jira] [Commented] (DOXIA-606) fix javadoc issues with JDK 8 when generating documentation
Date Mon, 14 Sep 2020 19:16:00 GMT

    [ https://issues.apache.org/jira/browse/DOXIA-606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195690#comment-17195690
] 

ASF GitHub Bot commented on DOXIA-606:
--------------------------------------

michaelboyles commented on a change in pull request #38:
URL: https://github.com/apache/maven-doxia/pull/38#discussion_r488162935



##########
File path: doxia-modules/doxia-module-markdown/src/test/java/org/apache/maven/doxia/module/markdown/MarkdownParserTest.java
##########
@@ -340,6 +340,7 @@ public void testHtmlContent()
      * @param file the file to parse with {@link #parser}.
      * @return a sink to test parsing events.
      * @throws ParseException if the document parsing failed.
+     * @throws IOException if an I/O error occurs while closing test reader.

Review comment:
       I copied the existing precedent. Would you rather I change the other ones which were
not affecting the build or make them inconsistent with one another?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> fix javadoc issues with JDK 8 when generating documentation
> -----------------------------------------------------------
>
>                 Key: DOXIA-606
>                 URL: https://issues.apache.org/jira/browse/DOXIA-606
>             Project: Maven Doxia
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 1.9.1
>            Reporter: Herve Boutemy
>            Assignee: Sylwester Lachiewicz
>            Priority: Major
>              Labels: up-for-grabs
>             Fix For: 1.9.2
>
>
> when building Doxia documentation with JDK 8:
> {noformat}mvn -Preporting site site:stage{noformat}
> some javadoc issues make site generation failure
> I had to build Doxia 1.9.1 release documentation with JDK 7, even if I built the artifacts
with JDK 8...
> for next release, it would be nice to not hit this issue any more



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message