maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-javadoc-plugin] XenoAmess commented on a change in pull request #52: [MJAVADOC-657] The fix operation duplicates annotations on private methods that have an annotation line between the method body and the javadoc comments.
Date Fri, 21 Aug 2020 14:08:56 GMT

XenoAmess commented on a change in pull request #52:
URL: https://github.com/apache/maven-javadoc-plugin/pull/52#discussion_r474721256



##########
File path: src/main/java/org/apache/maven/plugins/javadoc/AbstractFixJavadocMojo.java
##########
@@ -1052,9 +1052,12 @@ else if ( lineNumber == javaClass.getLineNumber() )
                     {
                         if ( lineNumber == method.getLineNumber() )
                         {
-                            changeDetected |= fixMethodComment( stringWriter, originalContent,
method, indent );
-
-                            takeCareSingleComment( stringWriter, originalContent, method
);
+                            final boolean ifItWillChangeNow = fixMethodComment( stringWriter,
originalContent, method, indent );

Review comment:
       @elharo done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message