From issues-return-169079-archive-asf-public=cust-asf.ponee.io@maven.apache.org Wed Jul 1 21:27:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 682E9180638 for ; Wed, 1 Jul 2020 23:27:02 +0200 (CEST) Received: (qmail 55520 invoked by uid 500); 1 Jul 2020 21:27:01 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 55497 invoked by uid 99); 1 Jul 2020 21:27:01 -0000 Received: from mailrelay1-us-west.apache.org (HELO mailrelay1-us-west.apache.org) (209.188.14.139) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2020 21:27:01 +0000 Received: from jira-he-de.apache.org (static.172.67.40.188.clients.your-server.de [188.40.67.172]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CAF7448720 for ; Wed, 1 Jul 2020 21:27:00 +0000 (UTC) Received: from jira-he-de.apache.org (localhost.localdomain [127.0.0.1]) by jira-he-de.apache.org (ASF Mail Server at jira-he-de.apache.org) with ESMTP id 25B79780A9E for ; Wed, 1 Jul 2020 21:27:00 +0000 (UTC) Date: Wed, 1 Jul 2020 21:27:00 +0000 (UTC) From: "Pavel_K (Jira)" To: issues@maven.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SUREFIRE-1811) Add resources to JPMS test module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SUREFIRE-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149704#comment-17149704 ] Pavel_K commented on SUREFIRE-1811: ----------------------------------- [~tibordigana] I have tried to find you in Skype using by your id "tibor.digana", however, when I enter it I see "Invite to Skype" or "Add funds" . Is this correct skype name? By the way I've found finally solutions for unit tests and IT tests on module path. For unit test - I will use the /test/java/module-info.java, for example `open module theSameNameAsMain \{...}` + package names of the unit tests = package names of the module under test. For IT test I will create separate maven projects (using the same parent pom as normal modules of the project). What do you think about such approach? > Add resources to JPMS test module > --------------------------------- > > Key: SUREFIRE-1811 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1811 > Project: Maven Surefire > Issue Type: New Feature > Components: Maven Failsafe Plugin > Affects Versions: 3.0.0-M5 > Reporter: Pavel_K > Priority: Major > > I am testing version 3.0.0-M5 with two module-info in one project - one main and one for test. My test project is here https://github.com/PashaTurok/hibernate-h2-test4 . The problem is with resources. For example, I have src/main/resources/META-INF/persistence.xml file that is not copied to test module. Because of this it is not possible to find resource in test module and it is necessary to use something like this https://github.com/PashaTurok/hibernate-h2-test4/blob/292e2e683ad72487cbf8d2e5a35dde0d9255001a/src/test/java/com/foo/hibernate/h2/test4/TestIT.java#L72 . > In target/test-classes/META-INF/jpms.args I see: > {code:java} > --patch-module > my.project=/home/..../hibernate-h2-test4/src/main/java, /home/.../hibernate-h2-test4/target/generated-sources/annotations > {code} > As I understand test module will NOT contain resources from the module under test? I mean that test module will NOT contain /home/..../hibernate-h2-test4/src/main/resources? > That's why I suggest to include src/main/resources in test module. -- This message was sent by Atlassian Jira (v8.3.4#803005)