maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Paal (Jira)" <j...@apache.org>
Subject [jira] [Commented] (MCHECKSTYLE-99) <includeTestSourceDirectory> should use default test sources xref output dir: ${project.reporting.outputDirectory}/xref-test
Date Sun, 12 Jul 2020 19:08:00 GMT

    [ https://issues.apache.org/jira/browse/MCHECKSTYLE-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17156367#comment-17156367
] 

Stefan Paal commented on MCHECKSTYLE-99:
----------------------------------------

i am aware this ticket was closed. still i also have the issue xref links in the checkstyle
report to test source files are broken. i prepared a pull request that introduces the parameter
{{xrefTestLocation}} to specify a custom location of the test source files. the default is
{{${project.reporting.outputDirectory}/xref-test}} and thus it will work out-of-the-box for
current checkstyle configurations and add the correct xref links in the checkstyle report.

[https://github.com/apache/maven-checkstyle-plugin/pull/34 |https://github.com/apache/maven-checkstyle-plugin/pull/34]

 

> <includeTestSourceDirectory> should use default test sources xref output dir: ${project.reporting.outputDirectory}/xref-test
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MCHECKSTYLE-99
>                 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-99
>             Project: Maven Checkstyle Plugin
>          Issue Type: Bug
>          Components: checkstyle:checkstyle
>    Affects Versions: 2.2
>         Environment: Linux (but I assume it happens in all environs)
>            Reporter: Dan Rollo
>            Priority: Major
>         Attachments: pom.xml
>
>
> The xref link to the Source pages in the checkstyle report page is
> broken. The source xref link for Unit Test Source files is not using the
> default value of the destDir for jxr test sources. From the jxr plugin docs
> for jxr:test-jxr:
> destDir
> Folder where the Xref files will be copied to.
>     * Type: java.lang.String
>     * Required: No
>     * Expression: ${project.reporting.outputDirectory}/xref-test
> I think the checkstyle plugin should:
>     - assume the default dir for jxr:test-jxr
>     - provide it's own additional override setting (similar to xrefLocation,
> but for test sources). like: testXrefLocation.
> A pom file exhibiting this problem is attached.
> Dan Rollo



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message