maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-javadoc-plugin] slachiewicz commented on a change in pull request #48: [MJAVADOC-653] fix javadoc; fix code smells; performance improvement
Date Tue, 14 Jul 2020 22:05:04 GMT

slachiewicz commented on a change in pull request #48:
URL: https://github.com/apache/maven-javadoc-plugin/pull/48#discussion_r454672648



##########
File path: src/test/java/org/apache/maven/plugins/javadoc/JavadocJarTest.java
##########
@@ -154,7 +154,7 @@ public void testInvalidDestdir()
         //check if the javadoc jar file was generated
         File generatedFile = new File( getBasedir(),
                                        "target/test/unit/javadocjar-invalid-destdir/target/javadocjar-invalid-destdir-javadoc.jar"
);
-        assertTrue( !FileUtils.fileExists( generatedFile.getAbsolutePath() ) );
+        assertFalse(FileUtils.fileExists(generatedFile.getAbsolutePath()));

Review comment:
       please check here: https://maven.apache.org/developers/conventions/code.html




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message