From issues-return-167227-archive-asf-public=cust-asf.ponee.io@maven.apache.org Fri Jun 5 19:01:10 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BFD9F18062C for ; Fri, 5 Jun 2020 21:01:09 +0200 (CEST) Received: (qmail 58550 invoked by uid 500); 5 Jun 2020 19:01:09 -0000 Mailing-List: contact issues-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@maven.apache.org Delivered-To: mailing list issues@maven.apache.org Received: (qmail 58537 invoked by uid 99); 5 Jun 2020 19:01:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Jun 2020 19:01:08 +0000 From: =?utf-8?q?GitBox?= To: issues@maven.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bmaven=5D_MartinKanters_commented_on_a_change_in_pu?= =?utf-8?q?ll_request_=23342=3A_=5BMNG-5760=5D_Add_--resume_/_-r_switch?= Message-ID: <159138366889.17834.15608711626264096215.asfpy@gitbox.apache.org> Date: Fri, 05 Jun 2020 19:01:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: MartinKanters commented on a change in pull request #342: URL: https://github.com/apache/maven/pull/342#discussion_r436109778 ########## File path: maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionManager.java ########## @@ -0,0 +1,306 @@ +package org.apache.maven.execution; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import com.google.common.annotations.VisibleForTesting; Review comment: Right, sounds like a good reason to remove it indeed. I will replace it with a comment then. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org