maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel_K (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (SUREFIRE-1811) Add resources to JPMS test module
Date Sat, 27 Jun 2020 05:54:00 GMT

    [ https://issues.apache.org/jira/browse/SUREFIRE-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146785#comment-17146785
] 

Pavel_K edited comment on SUREFIRE-1811 at 6/27/20, 5:53 AM:
-------------------------------------------------------------

[~sor] How do you think, how many module-info we should have? Two:
 # main/java/module-info,
 # test/java/module-info for unit and it tests

or three:
 # main/java/module-info,
 # test/java/module-info for unit tests
 # it/java/module-info) for it tests

And which of them should have same module names?


was (Author: pavel_k):
[~sor] How do you think, how many module-info we should have 2 (main/java/module-info, test/java/module-info)
or 3 (main/java/module-info, test/java/module-info, it/java/module-info)? And which of them
should have same module names?

> Add resources to JPMS test module
> ---------------------------------
>
>                 Key: SUREFIRE-1811
>                 URL: https://issues.apache.org/jira/browse/SUREFIRE-1811
>             Project: Maven Surefire
>          Issue Type: New Feature
>          Components: Maven Failsafe Plugin
>    Affects Versions: 3.0.0-M5
>            Reporter: Pavel_K
>            Priority: Major
>
> I am testing version 3.0.0-M5 with two module-info in one project - one main and one
for test. My test project is here https://github.com/PashaTurok/hibernate-h2-test4 . The problem
is with resources. For example, I have  src/main/resources/META-INF/persistence.xml file that
is not copied to test module. Because of this it is not possible to find resource in test
module and it is necessary to use something like this https://github.com/PashaTurok/hibernate-h2-test4/blob/292e2e683ad72487cbf8d2e5a35dde0d9255001a/src/test/java/com/foo/hibernate/h2/test4/TestIT.java#L72
. 
> In target/test-classes/META-INF/jpms.args I see:
> {code:java}
> --patch-module
> my.project=/home/..../hibernate-h2-test4/src/main/java, /home/.../hibernate-h2-test4/target/generated-sources/annotations
> {code}
> As I understand test module will NOT contain resources from the module under test? I
mean that test module will NOT contain /home/..../hibernate-h2-test4/src/main/resources? 
> That's why I suggest to include src/main/resources in test module.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message