maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "deckrider (Jira)" <j...@apache.org>
Subject [jira] [Comment Edited] (MWAR-433) Maven WAR plugin is deleting files generated by other plugins after upgrading to 3.3.0
Date Sun, 28 Jun 2020 13:00:00 GMT

    [ https://issues.apache.org/jira/browse/MWAR-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17147334#comment-17147334
] 

deckrider edited comment on MWAR-433 at 6/28/20, 12:59 PM:
-----------------------------------------------------------

[~hboutemy] indeed you are correct, I should not have responded until I got home!

I don't know why it is working for me and not you.  I removed my ~/.m2 directory altogether
and it still works.  Here is my environment:

{noformat}
$ mvn -version
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/share/apache-maven-3.6.3
Java version: 11.0.7, vendor: Azul Systems, Inc., runtime: /usr/local/lib/jvm/zulu11.39.15-ca-fx-jdk11.0.7-linux_x64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-108-generic", arch: "amd64", family: "unix"
{noformat}

And here is what happens when I give your answers:

{noformat}
Confirm properties configuration:
groupId: mwar
artifactId: mwar-433
version: 1.0-SNAPSHOT
package: mwar
module: mod
 Y: : 
[INFO] ----------------------------------------------------------------------------
[INFO] Using following parameters for creating project from Archetype: gwt-maven-plugin:2.9.0
[INFO] ----------------------------------------------------------------------------
[INFO] Parameter: groupId, Value: mwar
[INFO] Parameter: artifactId, Value: mwar-433
[INFO] Parameter: version, Value: 1.0-SNAPSHOT
[INFO] Parameter: package, Value: mwar
[INFO] Parameter: packageInPathFormat, Value: mwar
[INFO] Parameter: package, Value: mwar
[INFO] Parameter: groupId, Value: mwar
[INFO] Parameter: module, Value: mod
[INFO] Parameter: artifactId, Value: mwar-433
[INFO] Parameter: version, Value: 1.0-SNAPSHOT
[INFO] Project created from Archetype in dir: /home/deverly/tmp/mwar-433
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  56.999 s
[INFO] Finished at: 2020-06-28T06:39:37-06:00
[INFO] ------------------------------------------------------------------------
{noformat}

Unfortunately, I'm not sure what version I should use so as to test your newer version.  Do
I need to find the source and build it myself?

But I see the later discussion about opting in/out of the new behavior.  Assuming a fix that
handles both requirements is not found, It would be nice if the old behavior were the default
and the new behavior would need to be opted into -- especially if the  version number is not
changed to 4.0.0 ( as in #8 in https://semver.org/ ).

Thanks for your work and your patience!


was (Author: deckrider):
[~hboutemy] indeed you are correct, I should not have responded until I got home!

I don't know why it is working for me and not you.  I removed my ~/.m2 directory altogether
and it still works.  Here is my environment:

{noformat}
$ mvn -version
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /usr/local/share/apache-maven-3.6.3
Java version: 11.0.7, vendor: Azul Systems, Inc., runtime: /usr/local/lib/jvm/zulu11.39.15-ca-fx-jdk11.0.7-linux_x64
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-108-generic", arch: "amd64", family: "unix"
{noformat}

And here is what happens when I give your answers:

{noformat}
Confirm properties configuration:
groupId: mwar
artifactId: mwar-433
version: 1.0-SNAPSHOT
package: mwar
module: mod
 Y: : 
[INFO] ----------------------------------------------------------------------------
[INFO] Using following parameters for creating project from Archetype: gwt-maven-plugin:2.9.0
[INFO] ----------------------------------------------------------------------------
[INFO] Parameter: groupId, Value: mwar
[INFO] Parameter: artifactId, Value: mwar-433
[INFO] Parameter: version, Value: 1.0-SNAPSHOT
[INFO] Parameter: package, Value: mwar
[INFO] Parameter: packageInPathFormat, Value: mwar
[INFO] Parameter: package, Value: mwar
[INFO] Parameter: groupId, Value: mwar
[INFO] Parameter: module, Value: mod
[INFO] Parameter: artifactId, Value: mwar-433
[INFO] Parameter: version, Value: 1.0-SNAPSHOT
[INFO] Project created from Archetype in dir: /home/deverly/tmp/mwar-433
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  56.999 s
[INFO] Finished at: 2020-06-28T06:39:37-06:00
[INFO] ------------------------------------------------------------------------
{noformat}

Unfortunately, I'm not sure what version I should use so as to test your newer version.  Do
I need to find the source and build it myself?

But I see the later discussion about opting in/out of the new behavior.  Assuming a fix that
handles both requirements is no found, It would be nice if the old behavior were the default
and the new behavior would need to be opted into -- especially if the  version number is not
changed to 4.0.0 ( as in #8 in https://semver.org/ ).

Thanks for your work and your patience!

> Maven WAR plugin is deleting files generated by other plugins after upgrading to 3.3.0
> --------------------------------------------------------------------------------------
>
>                 Key: MWAR-433
>                 URL: https://issues.apache.org/jira/browse/MWAR-433
>             Project: Maven WAR Plugin
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: Kyle Lieber
>            Priority: Critical
>             Fix For: 3.3.1
>
>
> My project generates wsdls using the {{jaxws-maven-plugin}} which puts the generated
wsdls in {{${project.build.directory}/${project.build.finalName}/WEB-INF/wsdls}} so that they
are packaged up in the war file. Then I have a client jar that copies those wsdls out of the
war file using the {{maven-dependency-plugin}} and generates a client from the wsdls using
the {{jaxws-maven-plugin}}.
> This all works fine using {{3.2.3}} of the {{maven-war-plugin}}.  However, after upgrading
to {{3.3.0}} my project fails to build because the wsdls are no longer preserved.  It seems
that they are being deleted by the {{maven-war-plugin}}.
> I created an example project on Github which recreates the problem.  The {{master}} branch
is using {{3.2.3}} and the {{maven-war-plugin-3.3.0}} branch is using {{3.3.0}}.  You can
find more details in the readme file of the example project:
> https://github.com/klieber/maven-war-plugin-bug
> I also suspect that MWAR-427 is the change that introduced this bug.
> Please let me know if there is anymore information I can provide.  Thanks!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message