maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-archetype] newur commented on a change in pull request #35: ARCHETYPE-584 fix indention in root pom.xml
Date Fri, 05 Jun 2020 11:31:09 GMT

newur commented on a change in pull request #35:
URL: https://github.com/apache/maven-archetype/pull/35#discussion_r435860582



##########
File path: archetype-common/src/test/java/org/apache/maven/archetype/old/ArchetypeTest.java
##########
@@ -61,19 +61,11 @@
 public class ArchetypeTest
     extends PlexusTestCase
 {
-    private static final String XML_VERSION_1_0 =
-            "<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"no\"?>\n";
-    private static final String PROJECT_ELEMENT = "<project " +
-            "xmlns=\"http://maven.apache.org/POM/4.0.0\" " +
-            "xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\" " +
-            "xsi:schemaLocation=\"http://maven.apache.org/POM/4.0.0 " +
-            "http://maven.apache.org/xsd/maven-4.0.0.xsd\">\n";
-    private static final String PROJECT_ELEMENT_END = "</project>";
-    private static final String MODEL_VERSION = "  <modelVersion>4.0.0</modelVersion>\n";
-    private static final String PACKAGING = "  <packaging>pom</packaging>\n";
 
     private OldArchetype archetype;
 
+    private StringWriter out;

Review comment:
       It is initialized in the setup method. If I init it here it would be done twice. If
I remove it from the setup the tests would share state.
   
   Or do I miss something here?
   
   Btw if any maintainer _really_ wants it to be changed, please fell free to do so. Whatever
works best, I am fine with it. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message