maven-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [maven-shared-utils] elharo commented on a change in pull request #31: [MSHARED-681] createSymbolicLink() overwrites existing different symlinks
Date Sun, 17 May 2020 21:37:02 GMT

elharo commented on a change in pull request #31:
URL: https://github.com/apache/maven-shared-utils/pull/31#discussion_r426307551



##########
File path: src/test/java/org/apache/maven/shared/utils/io/FileUtilsTest.java
##########
@@ -1475,6 +1475,30 @@ public void createAndReadSymlink()
         Files.delete( file.toPath() );
     }
 
+    @Test
+    public void createSymbolicLinkWithDifferentTargetOverwritesSymlink()
+            throws Exception
+    {
+        assumeThat( System.getProperty( "os.name" ), not( startsWith( "Windows" ) ) );

Review comment:
       I'm a little concerned this might not work (it doesn't in some repos for reasons) so
we need to check this in Jenkins to make sure it passes on windows. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message